GNOME Bugzilla – Bug 737808
Remove broken cache size preference
Last modified: 2015-02-08 15:46:53 UTC
Lapo in #gnome-design agreed the app menu would be a good location for Clear Personal Data. Since this doesn't require any new strings, I think we have a chance at getting a UI freeze break for this for 3.14.1. Is it OK if I request one?
Created attachment 287623 [details] [review] Remove cache size preference It's not hooked up to anything, and there's no WebKit API for controlling cache size, and we're not going to add one. A casualty of this commit is the clear personal data dialog, which was previously located right next to the cache size spin button. That will be restored in the next commit.
Created attachment 287624 [details] [review] Add Clear Personal Data to app menu The button to launch this dialog was removed from the preferences dialog in the previous patch.
I'm not sure if the app menu is the best place for the clear personal data.
Nope, definitely not the app menu. Preferences would be a better place.
If we want it in preferences, we need help from a designer, since I have no clue where I would put it. (The app menu seemed like a good idea since the dialog has nothing to do with preferences. :)
We decided to remove the clear data dialog, cause the button to clear the browser cache (without deleting history, cookies, or passwords -- we have three other dialogs for those already), replace the cache size spin button with a sentence explaining the functionality of the button, and move the button to the right of that sentence. Maybe the sentence could be something like this: "You can clear temporary files that are cached on your computer. These files speed up web browsing, but can reveal your browsing history." There's no need to warn that the action cannot be undone, since it's just the cache. Actually, this should clear localstorage as well (though I bet it currently does not). I wonder if we need to warn about that?
Created attachment 292614 [details] [review] Remove the cache size preference and clear personal data dialog The cache size preference is next to the Clear Personal Data button, so to remove it we must find a better home for this button. Use a sentence label to explain the effect of the button, and remove the actual dialog, since all of the options are redundant with existing dialogs (passwords, cookies, history) except for clearing the cache. This is an initial implementation, probably not something to commit because it (a) could look better, and (b) I've been warned that there is not enough space f or translators.
Created attachment 296359 [details] [review] Remove cache size preference There is no way to set the cache size in WebKit2, and the max size is ludicrously lower (sans bugs) than anybody would care about. So this patch keeps the clear data dialog, which we agreed to remove, but I had a bit of trouble doing that with a professional-looking result. So this patch still launches the dialog when you press the button, which we can remove in the future if we want to.
Created attachment 296360 [details] screenshot We can also move the button up parallel to the heading, like it is for the other two buttons, but I think it looks better down lower.
Created attachment 296361 [details] [review] Remove cache size preference The last heading in the screeshot should be "Stored Data" not "Temporary Files"
Review of attachment 296361 [details] [review]: I guess this is ok, until we figure out how to properly rework the data cleanup in general. Please, remove also the definition of EPHY_PREFS_CACHE_SIZE in lib/ephy-prefs.h
Created attachment 296384 [details] [review] Remove cache size preference There is no way to set the cache size in WebKit2, and the max size is ludicrously lower (sans bugs) than anybody would care about.
The following fix has been pushed: 3a26cf2 Remove cache size preference
Created attachment 296385 [details] [review] Remove cache size preference There is no way to set the cache size in WebKit2, and the max size is ludicrously lower (sans bugs) than anybody would care about.