After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737785 - no generic button class/style
no generic button class/style
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-02 15:09 UTC by Jakub Steiner
Modified: 2015-02-20 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theme: a button is a button is a button (13.23 KB, patch)
2015-01-16 14:34 UTC, Jakub Steiner 		committed Details | Review

Description Jakub Steiner 2014-10-02 15:09:57 UTC 
We seem to define a generic button style for each and every button type:

.candidate-page-button,
.notification-button,
.notification-icon-button,
.hotplug-notification-item,
.hotplug-resident-eject-button,
.modal-dialog-button,
.app-view-control {}

Would be nice if all these button just had a 'button' class associated.
Comment 1 Florian Müllner 2014-10-02 20:28:30 UTC 
(In reply to comment #0)
> We seem to define a generic button style for each and every button type:
> 
> .candidate-page-button,
> .notification-button,
> .notification-icon-button,
> .hotplug-notification-item,
> .hotplug-resident-eject-button,
> .modal-dialog-button,
> .app-view-control {}
> 
> Would be nice if all these button just had a 'button' class associated.

It's not a big deal sticking another style class in there, but all of the above can already be addressed as 'StButton' ...
Comment 2 Lapo Calamandrei 2014-10-04 22:02:56 UTC 
Yeah, but I think it makes sense to use the same gtk+ logic for the css. In gtk+ we try to avoid as much as possible to use widget names preferring generic classes so say a GtkButton, a GtkToggleButton and a GtkComboBox could share the same style.
Using the same logic (where possible) in shell makes sense so there's less learning involved in styling both and where makes sense the same style could be shared.
Comment 3 Jakub Steiner 2015-01-16 14:34:32 UTC 
Created attachment 294690 [details] [review]
theme: a button is a button is a button
Comment 4 Florian Müllner 2015-02-20 16:46:30 UTC 
Attachment 294690 [details] pushed as 48cfd35 - theme: a button is a button is a button