After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737744 - ges formatter: Load and save children properties from track elements
ges formatter: Load and save children properties from track elements
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-01 20:11 UTC by Lubosz Sarnecki
Modified: 2018-11-03 12:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This patch enables the formatter to load and store children properties on track elements. (10.91 KB, patch)
2014-10-01 20:11 UTC, Lubosz Sarnecki
none Details | Review
Change time values in tests (1.71 KB, patch)
2014-10-01 20:20 UTC, Lubosz Sarnecki
none Details | Review
Add children properties check (7.71 KB, patch)
2014-10-01 20:22 UTC, Lubosz Sarnecki
none Details | Review

Description Lubosz Sarnecki 2014-10-01 20:11:02 UTC
Created attachment 287539 [details] [review]
This patch enables the formatter to load and store children properties on track elements.

The ges-base-xml-formatter.c is currently unable to load and store children-properties from track elements.

This is needed to store and load position and size from clips, like in this xges example:
http://wiki.pitivi.org/wiki/XGES_Examples#Clip_Position_and_Size

A track element is described with a <source> XML tag. The example does not work without these patches, and Pitivi is not able to store values on track elements. There is no other way to manipulate the dimension of the clip in ges.

This is a series of patches written by Joris Valette.

He published them in following Github ticktes:
https://github.com/pitivi/gst-editing-services/issues/54
https://github.com/pitivi/gst-editing-services/issues/56

Since these patches never made it through code review, I am willing to improve them so they can get merged.
Comment 1 Lubosz Sarnecki 2014-10-01 20:20:43 UTC
Created attachment 287541 [details] [review]
Change time values in tests

I am not sure if this is needed, the tests pass without it. But I post it for completeness. Apparently he thought that time values needed to be changed for the tests to work.

This patch is discussed in:
https://github.com/pitivi/gst-editing-services/issues/56
Comment 2 Lubosz Sarnecki 2014-10-01 20:22:12 UTC
Created attachment 287542 [details] [review]
Add children properties check

This patch renames the keyframes test from make check and adds children properties for track elements (posx).
Comment 3 GStreamer system administrator 2018-11-03 12:52:30 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/18.