After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737727 - should not enclose dhcp-client-identifier in double quotes
should not enclose dhcp-client-identifier in double quotes
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: IP and DNS config
0.9.8
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-10-01 14:51 UTC by Johannes Rohr
Modified: 2014-10-27 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dhclient: allow single hex digits in hexadecimal dhcp_client_id (3.52 KB, patch)
2014-10-07 13:59 UTC, Thomas Haller 		accepted-commit_now Details | Review

Description Johannes Rohr 2014-10-01 14:51:31 UTC 
the latest version breaks the use of dhcp-client-identifier by generating a dhclient.conf, in which the client identifier string is enclosed in double quotes. 

Since it is a hex string it should not be in quotes.
Comment 1 Johannes Rohr 2014-10-01 15:15:33 UTC 
Just found out what is going on here:

src/dhcp-manager/nm-dhcp-dhclient-utils.c 

tries to determine whether the dhcp-client-identifier is a hex string or not. 

The string I used was something like

1:0:ab:aa:ab

which is a perfectly acceptable hex string for dhclient

When I change this to

01:00:ab:aa:ab

it works, there are no quotes in the generated dhclient.conf

So maybe the test should be changed to accommodate such cases...
Comment 2 Thomas Haller 2014-10-07 13:59:43 UTC 
Created attachment 287964 [details] [review]
dhclient: allow single hex digits in hexadecimal dhcp_client_id

When checking whether the dhcp-client-identifier is a hex string,
we expected pairs of hexadecimal digits separated by colon.
Relax this check to also allow single hex digits.

https://bugzilla.gnome.org/show_bug.cgi?id=737727

Signed-off-by: Thomas Haller <thaller@redhat.com>
Comment 3 Dan Williams 2014-10-09 02:53:52 UTC 
Review of attachment 287964 [details] [review]:

Looks good to me.