After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737711 - quick open crashes when I press Enter
quick open crashes when I press Enter
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-01 11:06 UTC by Adam Dingle
Modified: 2019-03-23 20:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.00 KB, patch)
2014-10-01 14:49 UTC, Adam Dingle 		none Details | Review
updated patch (1.19 KB, patch)
2014-10-03 14:30 UTC, Adam Dingle 		accepted-commit_now Details | Review

Description Adam Dingle 2014-10-01 11:06:48 UTC 
I'm running gedit from git master on Ubuntu 14.10 with GTK 3.14.1.

1. Enable the Quick Open plugin.
2. Press Ctrl+Alt+O to open the Quick Open dialog.
3. Press Enter to select the first file in the list.  gedit will crash with a segmentation fault.

Here's a stack trace:

(gdb) where

+ Trace 234156

  • #0 gdk_window_has_impl
    at gdkwindow.c line 583
  • #1 _gdk_window_has_impl
    at gdkwindow.c line 584
  • #2 gdk_x11_window_get_xid
    at gdkwindow-x11.c line 5577
  • #3 gtk_im_context_xim_filter_keypress
    at gtkimcontextxim.c line 673
  • #4 gtk_im_multicontext_filter_keypress
    at gtkimmulticontext.c line 361
  • #5 gtk_entry_key_press
    at gtkentry.c line 4852
  • #6 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 85
  • #7 g_closure_invoke
    at /build/buildd/glib2.0-2.41.5/./gobject/gclosure.c line 768
  • #8 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.41.5/./gobject/gsignal.c line 3591
  • #9 g_signal_emit_valist
    at /build/buildd/glib2.0-2.41.5/./gobject/gsignal.c line 3319
  • #10 g_signal_emit
    at /build/buildd/glib2.0-2.41.5/./gobject/gsignal.c line 3365
  • #11 gtk_widget_event_internal
    at gtkwidget.c line 7773
  • #12 gtk_window_propagate_key_event
    at gtkwindow.c line 7596
  • #13 gtk_window_key_press_event
    at gtkwindow.c line 7629
  • #14 _gtk_marshal_BOOLEAN__BOXEDv
    at gtkmarshalers.c line 130
  • #15 _g_closure_invoke_va
    at /build/buildd/glib2.0-2.41.5/./gobject/gclosure.c line 831
  • #16 g_signal_emit_valist
  • #17 g_signal_emit
    at /build/buildd/glib2.0-2.41.5/./gobject/gsignal.c line 3365
  • #18 gtk_widget_event_internal
    at gtkwidget.c line 7773
  • #19 propagate_event
    at gtkmain.c line 2507
  • #20 gtk_main_do_event
    at gtkmain.c line 1748
  • #21 gdk_event_source_dispatch
    at gdkeventsource.c line 364
  • #22 g_main_dispatch
    at /build/buildd/glib2.0-2.41.5/./glib/gmain.c line 3064
  • #23 g_main_context_dispatch
    at /build/buildd/glib2.0-2.41.5/./glib/gmain.c line 3663
  • #24 g_main_context_iterate
    at /build/buildd/glib2.0-2.41.5/./glib/gmain.c line 3734
  • #25 g_main_context_iteration
    at /build/buildd/glib2.0-2.41.5/./glib/gmain.c line 3795
  • #26 g_application_run
    at /build/buildd/glib2.0-2.41.5/./gio/gapplication.c line 2282
  • #27 main
    at gedit/gedit.c line 135 






Comment 1


Ignacio Casal Quinteiro (nacho)





          2014-10-01 11:11:13 UTC
        



a bug in ubuntu's gtk?






Comment 2


Adam Dingle





          2014-10-01 11:21:02 UTC
        



It can't be, since I built GTK myself from the gtk-3-14 branch with no Ubuntu patches applied.

Nacho, are you able to reproduce this?






Comment 3


sébastien lafargue





          2014-10-01 11:21:51 UTC
        



can't reproduce it in jhbuild and rawhide






Comment 4


Garrett Regier





          2014-10-01 13:21:18 UTC
        



I can reproduce this 100% when running gedit with GTK_IM_MODULE=xim as implied by the backtrace.

Anyone else?






Comment 5


sébastien lafargue





          2014-10-01 13:35:09 UTC
        



crash for me too with GTK_IM_MODULE=xim






Comment 6


Adam Dingle





          2014-10-01 14:49:33 UTC
        



Created attachment 287522 [details] [review]
fix

This patch fixes this on my machine.






Comment 7


Matthias Clasen





          2014-10-01 15:26:21 UTC
        



thats a gedit patch






Comment 8


Adam Dingle





          2014-10-01 15:28:49 UTC
        



True.  Currently this is classified as a gedit bug.  Matthias, do you believe this is a GTK bug and should be fixed there?






Comment 9


Matthias Clasen





          2014-10-01 15:33:20 UTC
        



I haven't looked at the bug at all, just moved the bug back to where the patch applies. Feel free to move it back to gtk, but my expectation of fixes for the xim module magically appearing is pretty low. I recommend using IBus.






Comment 10


Adam Dingle





          2014-10-02 11:52:56 UTC
        



I'd still be inclined to commit this patch to gedit - it's a simple 2-line fix that will prevent anyone else from being burned by this if they're using xim.  (I myself had to disable IBus to work around another problem.)  Nacho or other gedit developers, what do you think?






Comment 11


jessevdk@gmail.com





          2014-10-02 20:59:56 UTC
        



It's kind of lame, but I'm fine if it fixes the issue I guess. Please add comments though why it's required to destroy in idle, so future us doesn't think it's weird and removes it.






Comment 12


Adam Dingle





          2014-10-03 14:30:28 UTC
        



Created attachment 287673 [details] [review]
updated patch

OK - I've updated the patch with comments as requested.  Let me know if you think this is OK to push.






Comment 13


jessevdk@gmail.com





          2014-10-03 14:35:49 UTC
        



Review of attachment 287673 [details] [review]:

Looks good to me






Comment 14


Adam Dingle





          2014-10-03 15:26:07 UTC
        



OK - I committed this, and also backported to gnome-3-12 and gnome-3-10.