After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737706 - videoencoder: release frame in finish_frame when no output state is configured
videoencoder: release frame in finish_frame when no output state is configured
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-01 09:29 UTC by Aurélien Zanelli
Modified: 2014-10-14 07:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoencoder: release frame in finish_frame when no output state is configured (918 bytes, patch)
2014-10-01 09:30 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2014-10-01 09:29:33 UTC 
When no output state is configured, the finish_frame method doesn't release frame.
Since frame is marked as transfer full, I think it's a bug.
Comment 1 Aurélien Zanelli 2014-10-01 09:30:41 UTC 
Created attachment 287501 [details] [review]
videoencoder: release frame in finish_frame when no output state is configured

Otherwise, frame is leaked.

(I think, it should be backported in 1.4 if confirmed)
Comment 2 Sebastian Dröge (slomo) 2014-10-01 09:55:04 UTC 
Will backport to 1.4 later

commit 9297fe9ba05e7d09f0cb1bd26d37c8ad6359914d
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Wed Oct 1 11:16:30 2014 +0200

    videoencoder: release frame in finish_frame when no output state is configured
    
    Otherwise, frame is leaked.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737706