After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737701 - GJS shouldn't require cairo-xlib
GJS shouldn't require cairo-xlib
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2014-10-01 07:43 UTC by Philip Chimento
Modified: 2017-04-13 23:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the problem (1.05 KB, patch)
2014-10-01 07:43 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2014-10-01 07:43:06 UTC 
Created attachment 287498 [details] [review]
Patch to fix the problem

When building on OSX we are using Cairo without XLib support, so XLib should not be required. This changes the PKG_CHECK_MODULES call to issue a warning instead of erroring out if cairo-xlib.pc is not found.

(The cairo-xlib dependency is in order to initialize XLib threads properly, but if there is no XLib, we don't need to initialize XLib threads, either.)

I'd appreciate it if this could be committed to the gnome-3-14 branch as well.
Comment 1 Giovanni Campagna 2014-10-06 19:43:10 UTC 
Review of attachment 287498 [details] [review]:

Looks good.
Comment 2 Philip Chimento 2014-10-06 20:02:23 UTC 
OK for me to commit to both master and gnome-3-14 then?
Comment 3 Philip Chimento 2014-11-26 21:28:16 UTC 
Committed to both master and gnome-3-14.