After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737584 - configure.ac: require GLib 2.34
configure.ac: require GLib 2.34
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-29 12:45 UTC by Aurélien Zanelli
Modified: 2014-09-29 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure.ac: require GLib 2.34 (726 bytes, patch)
2014-09-29 12:46 UTC, Aurélien Zanelli
needs-work Details | Review
gst-plugins-base- configure.ac: require GLib 2.34 (656 bytes, patch)
2014-09-29 12:50 UTC, Aurélien Zanelli
rejected Details | Review
gst-plugins-good configure.ac: require GLib 2.34 (627 bytes, patch)
2014-09-29 12:52 UTC, Aurélien Zanelli
rejected Details | Review
gst-plugins-bad configure.ac: require GLib 2.34 (728 bytes, patch)
2014-09-29 12:53 UTC, Aurélien Zanelli
rejected Details | Review
gst-plugins-ugly configure.ac: require GLib 2.34 (672 bytes, patch)
2014-09-29 12:56 UTC, Aurélien Zanelli
rejected Details | Review

Description Aurélien Zanelli 2014-09-29 12:45:40 UTC
gsturi now use g_list_deep_copy() which is available since glib-2.34
Comment 1 Aurélien Zanelli 2014-09-29 12:46:24 UTC
Created attachment 287341 [details] [review]
configure.ac: require GLib 2.34
Comment 2 Aurélien Zanelli 2014-09-29 12:50:25 UTC
Created attachment 287343 [details] [review]
gst-plugins-base- configure.ac: require GLib 2.34
Comment 3 Aurélien Zanelli 2014-09-29 12:52:07 UTC
Created attachment 287345 [details] [review]
gst-plugins-good configure.ac: require GLib 2.34
Comment 4 Aurélien Zanelli 2014-09-29 12:53:49 UTC
Created attachment 287346 [details] [review]
gst-plugins-bad configure.ac: require GLib 2.34
Comment 5 Aurélien Zanelli 2014-09-29 12:56:42 UTC
Created attachment 287347 [details] [review]
gst-plugins-ugly configure.ac: require GLib 2.34
Comment 6 Sebastian Dröge (slomo) 2014-09-29 13:07:03 UTC
Or maybe we should just #define compatibility wrappers for that function for older glib as we do elsewhere :) Doesn't seem worth it to update the GLib dependency just because of this
Comment 7 Tim-Philipp Müller 2014-09-29 13:07:49 UTC
We might decide to bump the GLib requirement this cycle, but certainly not for something as trivial and silly as g_list_copy_deep() :)
Comment 8 Aurélien Zanelli 2014-09-29 14:47:15 UTC
Ok, I will write a wrapper, I should have asked on IRC first :)
Comment 9 Sebastian Dröge (slomo) 2014-09-29 14:49:27 UTC
commit 2b6298ebc5277f939083123480a430cc4ffe9c1d
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Sep 29 17:48:29 2014 +0300

    uri: Don't unconditionally use g_list_copy_deep()
    
    We don't depend on GLib 2.34 yet and just for this seems a bit useless.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737584