GNOME Bugzilla – Bug 737575
Panel crashes when trying to click on clock applet
Last modified: 2014-11-14 17:09:17 UTC
Using gnome-panel 3.8.1-4 from Debian. Steps to reproduce the crash: - Add some locations to the clock applet. - Disconnect from the Internet. - (Re)start the gnome-panel. - Click on the clock applet. Backtrace:
+ Trace 234140
Created attachment 290167 [details] Valgrind log I can still reproduce this crash with gnome-panel 3.14.0. Attached is the Valgrind log. The errors start happening after I click the applet, no errors before that.
Have you tried to find what exactly is causing crash? Will you be able to test with 3.15? I am rewriting ClockFace and ClockLocationTitle with hope that this bug will be fixed.
(In reply to comment #2) > Have you tried to find what exactly is causing crash? `priv` is null pointer, and the code tries to dereference it. Unfortunately I don't know Gtk+ enough to know why it was deleted, but the Valgrind log should be very informative. > Will you be able to test with 3.15? I am rewriting ClockFace and > ClockLocationTitle with hope that this bug will be fixed. The crash is still there with current master :-( New backtrace (pasting plain so that Bugzilla can recognize it):
+ Trace 234323
(In reply to comment #3) > > Will you be able to test with 3.15? I am rewriting ClockFace and > > ClockLocationTitle with hope that this bug will be fixed. > > The crash is still there with current master :-( Please test with wip/applets/clock.
With that branch I can't reproduce the crash. However, now sometimes (maybe one time of two) I get my location listed twice after I click on the clock applet (tested offline). In the preferences dialog it is listed only once. Will it be possible to have a minimal patch to fix the crash, for Debian Jessie / Ubuntu SRU?
(In reply to comment #5) > With that branch I can't reproduce the crash. Nice. > However, now sometimes (maybe one time of two) I get my location listed twice > after I click on the clock applet (tested offline). In the preferences dialog > it is listed only once. This might help find real problem. I plan to rewrite other parts so this probably will be fixed. > Will it be possible to have a minimal patch to fix the crash, for Debian Jessie > / Ubuntu SRU? I did not plan this, but above info could help to find real problem. I did not change how ClockLocationTile[s] are created. When I will have time I will try to solve this first in master.
Could you test both master and wip branch after you remove this line: https://git.gnome.org/browse/gnome-panel/tree/applets/clock/clock.c#n1216 1. In master just test if it does not crash and there is no visible regression. After setting current city there is no reason to update settings nor any reason to recreate cities store. 2. In wip branch check if this fix problem with locations listed twice. I have no access to my main pc, I can not test master nor wip branch. P.S. This bug probably is regression since this commit: https://git.gnome.org/browse/gnome-panel/commit/applets/clock/clock.c?id=96e1070f3c7c69282283b19d6b7b5ef93a10fe15
master — still crashing wip/applets/clock — I don't see any new commits, did you push them?
I did not push this to wip nor to master. Before testing remove that line - save_cities_store.
Oh sorry, I did not read first line of your message. Everything seems to be fixed after removing that line — crash with master, and double entry with wip/applets/clock. Thanks a lot for debugging! I still have some Valgrind warnings printed (different this time), but these seem to be related to rsvg code, not gnome-panel code. Once the patch is in master, I will prepare a gnome-panel upload for Debian testing with this fix. Let me know if there is something else you would like me to include.
(In reply to comment #10) > Oh sorry, I did not read first line of your message. > > Everything seems to be fixed after removing that line — crash with master, and > double entry with wip/applets/clock. Thanks a lot for debugging! Nice to hear. > I still have some Valgrind warnings printed (different this time), but these > seem to be related to rsvg code, not gnome-panel code. Wip branch does not depend on rsvg code anymore. I have removed this dependency by rewriting ClockFace. > Once the patch is in master, I will prepare a gnome-panel upload for Debian > testing with this fix. Let me know if there is something else you would like me > to include. Ok, pushed to master. You can include this one: https://git.gnome.org/browse/gnome-panel/commit/?id=6ca0e5dee4142d7995827b28ff674006ee3f8dd4
(In reply to comment #11) > > I still have some Valgrind warnings printed (different this time), but these > > seem to be related to rsvg code, not gnome-panel code. > > Wip branch does not depend on rsvg code anymore. I have removed this dependency > by rewriting ClockFace. It uses it indirectly: ... 0xEBB0759: rsvg_handle_get_pixbuf (rsvg.c:119) 0xBF96AC0: gdk_pixbuf__svg_image_stop_load (io-svg.c:160) 0x4B1B998: gdk_pixbuf_loader_close (in libgdk_pixbuf-2.0.so.0) 0x4B1958C: gdk_pixbuf_new_from_stream_at_scale (in libgdk_pixbuf-2.0.so.0) 0x4B198A1: gdk_pixbuf_new_from_resource_at_scale (in libgdk_pixbuf-2.0.so.0) 0xBF41245: clock_face_get_pixbuf (clock-face.c:212) 0xBF41B12: clock_face_hour_changed (clock-face.c:239) ...