After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737569 - tsdemux: valid data is discarded if PES start packet is the first packet after discontinuity
tsdemux: valid data is discarded if PES start packet is the first packet afte...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal minor
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-29 08:55 UTC by Jesper Larsen
Modified: 2014-10-14 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tsdemux: do not discard on discont if PES start (1.05 KB, patch)
2014-09-29 08:55 UTC, Jesper Larsen 		committed Details | Review

Description Jesper Larsen 2014-09-29 08:55:17 UTC 
Created attachment 287327 [details] [review]
tsdemux: do not discard on discont if PES start

If a discontinuity in the stream is detected the incoming data is discarded until a new PES packet start is received.

If the discontinuity is detected at a PES packet start, this means that an entire valid PES packet is discarded.

The attached patch will prevent a PES packet from being discarded, if it starts when the discontinuity is detected.
Comment 1 Edward Hervey 2014-09-29 09:43:05 UTC 
Well spotted !

commit 1b8e76d235f4adc42fdbc2f4b63f822d74097622
Author: Jesper Larsen <knorr.jesper@gmail.com>
Date:   Mon Sep 29 10:01:27 2014 +0200

    tsdemux: do not discard on discont if PES start
    
    If a discontinuity in the stream is detected, data is discarded until
    a new PES starts. If the first packet after the discontinuity is also
    the start of a PES, there is no reason to discard the packets.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737569