After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737549 - GOA dialogs are not opened after cancellation
GOA dialogs are not opened after cancellation
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.14.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-28 20:52 UTC by Balló György
Modified: 2014-10-13 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix a life-cycle issue in the oauth2 provider (1.35 KB, patch)
2014-10-10 18:23 UTC, Matthias Clasen 		committed Details | Review

Description Balló György 2014-09-28 20:52:37 UTC 
GOA dialogs are not opened after cancellation with gnome-initial-setup 3.14.0 and gnome-online-accounts 3.14.0.

Steps to reproduce:
1. Run gnome-initial-setup.
2. On the Online Accounts page click on a provider (e.g. Google).
3. The log in dialog opened. Click on the Cancel button.
4. Try to open the dialog of the same provider again.
5. The dialog won't be opened, instead it throws the following error on command line:
(gnome-initial-setup:2626): GoaBackend-CRITICAL **: get_tokens_and_identity: assertion 'priv->error == NULL' failed

Distribution is Arch Linux.
Comment 1 Matthias Clasen 2014-10-10 18:23:08 UTC 
Created attachment 288249 [details] [review]
Fix a life-cycle issue in the oauth2 provider

When calling g_propagate_error on an error, the src becomes invalid,
but you have to clear your pointer yourself, if you want to keep
using it.
Comment 2 Debarshi Ray 2014-10-10 21:04:09 UTC 
Review of attachment 288249 [details] [review]:

Looks good to me, thanks! It went unnoticed because the Settings panel destroys the provider object on cancellation, and uses a new one on the second attempt.
Comment 3 Matthias Clasen 2014-10-13 15:11:03 UTC 
Attachment 288249 [details] pushed as a251f21 - Fix a life-cycle issue in the oauth2 provider