After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737540 - Freebase: async topic queries use the wrong result gtype
Freebase: async topic queries use the wrong result gtype
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
git master
Other Mac OS
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-28 17:41 UTC by Carlos Garnacho
Modified: 2014-12-23 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
freebase: Create async topic replies with the correct GType (1.19 KB, patch)
2014-09-28 17:42 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2014-09-28 17:41:39 UTC 
I missed to notice this when testing... gdata_freebase_service_get_topic_async() creates an object of type GDATA_TYPE_FREEBASE_RESULT asynchronously, although it should be a GDATA_TYPE_FREEBASE_TOPIC_RESULT.

I'm attaching a patch
Comment 1 Carlos Garnacho 2014-09-28 17:42:14 UTC 
Created attachment 287300 [details] [review]
freebase: Create async topic replies with the correct GType

The async version was wrongly using the parent type, so the returned object
wasn't a GDataFreebaseTopicResult at all.
Comment 2 Philip Withnall 2014-09-30 08:03:19 UTC 
Review of attachment 287300 [details] [review]:

++, though the same comment about regression tests applies as from bug #737539.
Comment 3 Carlos Garnacho 2014-10-05 17:02:45 UTC 
(In reply to comment #2)
> Review of attachment 287300 [details] [review]:
> 
> ++, though the same comment about regression tests applies as from bug #737539.

The tests I attached to that bug cover this issue :)
Comment 4 Philip Withnall 2014-10-16 08:29:53 UTC 
Comment on attachment 287300 [details] [review]
freebase: Create async topic replies with the correct GType

(In reply to comment #3)
> The tests I attached to that bug cover this issue :)

Great! Please commit to master.
Comment 5 Carlos Garnacho 2014-12-23 10:20:22 UTC 
Attachment 287300 [details] pushed as 0e3915c - freebase: Create async topic replies with the correct GType