After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737533 - windows: Stop overriding the Gtk/DecorationLayout xsetting
windows: Stop overriding the Gtk/DecorationLayout xsetting
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
3.14.1
Depends on:
Blocks:
 
 
Reported: 2014-09-28 15:58 UTC by Florian Müllner
Modified: 2014-09-29 13:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
windows: Stop overriding the Gtk/DecorationLayout xsetting (2.49 KB, patch)
2014-09-28 15:58 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-09-28 15:58:54 UTC 
The override interferes with gnome-settings-daemon setting Gtk/DecorationLayout according to the button-layout setting, see patch.
Comment 1 Florian Müllner 2014-09-28 15:58:56 UTC 
Created attachment 287296 [details] [review]
windows: Stop overriding the Gtk/DecorationLayout xsetting

gnome-settings-daemon monitors the button-layout setting and uses
it to set Gtk/Decoration - unless there's an explicit override.
In the best case, the override matches the setting and it doesn't
make any difference, in all other cases it causes client- and
server-side decorations to go out of sync.
Comment 2 Matthias Clasen 2014-09-29 10:49:06 UTC 
good candidate for 3.14.1
Comment 3 Matthias Clasen 2014-09-29 10:51:38 UTC 
Review of attachment 287296 [details] [review]:

looks right to me
Comment 4 Florian Müllner 2014-09-29 13:52:13 UTC 
Attachment 287296 [details] pushed as 33550a2 - windows: Stop overriding the Gtk/DecorationLayout xsetting