After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737510 - Ignores G_FILE_COPY_NO_FALLBACK_FOR_MOVE for push/pull
Ignores G_FILE_COPY_NO_FALLBACK_FOR_MOVE for push/pull
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: client module
1.22.x
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-28 08:29 UTC by Ross Lagerwall
Modified: 2014-10-17 19:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
client: Check for G_FILE_COPY_NO_FALLBACK_FOR_MOVE when push/pulling (1.08 KB, patch)
2014-09-28 08:35 UTC, Ross Lagerwall 		committed Details | Review
gvfs-move: Allow specifying G_FILE_COPY_NO_FALLBACK_FOR_MOVE (2.35 KB, patch)
2014-09-28 08:35 UTC, Ross Lagerwall 		committed Details | Review

Description Ross Lagerwall 2014-09-28 08:29:38 UTC 
The client module ignores G_FILE_COPY_NO_FALLBACK_FOR_MOVE for push/pull which makes Nautilus not display the progress bar when push/pulling multiple selected files.
Comment 1 Ross Lagerwall 2014-09-28 08:35:21 UTC 
Created attachment 287271 [details] [review]
client: Check for G_FILE_COPY_NO_FALLBACK_FOR_MOVE when push/pulling

Fail if G_FILE_COPY_NO_FALLBACK_FOR_MOVE is specified and either a pull
or a push is going to be executed.
Comment 2 Ross Lagerwall 2014-09-28 08:35:26 UTC 
Created attachment 287272 [details] [review]
gvfs-move: Allow specifying G_FILE_COPY_NO_FALLBACK_FOR_MOVE

Allow specifying G_FILE_COPY_NO_FALLBACK_FOR_MOVE when moving by passing
"-c" to gvfs-move.
Comment 3 Ondrej Holy 2014-09-29 11:43:27 UTC 
Review of attachment 287271 [details] [review]:

Makes sense, but it would be better to commit after we branch master, because it slightly changes the current behavioral of g_file_move...
Comment 4 Ondrej Holy 2014-09-29 11:51:52 UTC 
Review of attachment 287272 [details] [review]:

I've just realized almost all negative options have short option with capital letter, e.g. gvfs-copy:

-T, --no-target-directory
-P, --no-dereference

So it should be -C, not -c.
Comment 5 Ross Lagerwall 2014-10-17 19:40:26 UTC 
Pushed to master as 0077603d193ddd8c3c6f2d7f9053808b0ff1f944 (with a slight fixup). Thanks for the review!