GNOME Bugzilla – Bug 737499
Don't throw away the 512px icon
Last modified: 2014-10-09 02:09:25 UTC
commit 409d4773d52b0080a1d94e0c62a7acc8619098ed should probably be reverted. It removes the 512x512 icon in an attempt to get rid of "Gdk-WARNING **: gdk_window_set_icon_list: icon too large (512x512)" The solution is to friggin' fix GDK, not downgrade our artwork. There's a reason why the 512² icon is there. Removing it hides the problem under the rug and our icon will look blurry on high-DPI ("retina") displays.
There's nothing to fix in gdk, we're limited by the X max property size. Just don't add giant icons to the window icon list. You can still install them in the hicolor icon theme, where the shell will still pick them up based on the icon name in the desktop file.
Matthias, we could load the icons manually like this: https://github.com/aleb/pitivi/commit/a1db447e4e4cadf94de7334e9d45f6fcc00906a8 Or we could duplicate the "pitivi" icon used by pitivi.desktop and by the main window self.set_icon_name("pitivi"). Which do you think is best?
I decided to just remove the warning in gtk.
OK, let's just revert that commit I guess then.
Mental note: there is a reversal commit for this in aleb's "highlighting" branch.
commit 15243569a6f8990aa8dc162abe757c7315e21948 Author: Alexandru Băluț <alexandru.balut@gmail.com> Date: Wed Oct 1 20:08:21 2014 +0200 Revert "gdk: fix icon too large warning" The warning will be removed in Gtk. Fixes https://bugzilla.gnome.org/show_bug.cgi?id=737499 This reverts commit 409d4773d52b0080a1d94e0c62a7acc8619098ed.