After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737493 - Crashes when no keyboard layout selected
Crashes when no keyboard layout selected
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
3.14.x
Other Linux
: Normal major
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-27 16:48 UTC by Balló György
Modified: 2014-10-09 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
CcInputChooser: avoid crashing when no input source is set (1.96 KB, patch)
2014-09-29 18:10 UTC, Rui Matos 		committed Details | Review
keyboard: Don't allow moving forward without an input source (2.24 KB, patch)
2014-09-29 18:10 UTC, Rui Matos 		committed Details | Review

Description Balló György 2014-09-27 16:48:40 UTC 
gnome-initial-setup 3.14.0 crashes when no keyboard layout selected.

Steps to reproduce:
1. Run GDM in initial setup mode.
2. Select Hungarian language, and click next.
3. Hungarian keyboard layouts are listed, but no one is selected by default. Click on the next button without selecting any layout.
4. gnome-initial-setup crashes:
gnome-initial-s[1078]: segfault at 0 ip 00007fcf7dd72ab6 sp 00007fffe0fc70d8 error 4 in libc-2.20.so[7fcf7dc4b000+199000]

Distribution is Arch Linux.
Comment 1 Rui Matos 2014-09-29 18:10:47 UTC 
Created attachment 287391 [details] [review]
CcInputChooser: avoid crashing when no input source is set

priv->id and priv->type are NULL on locales where we don't have a
default input source. We shouldn't crash in that case.
Comment 2 Rui Matos 2014-09-29 18:10:55 UTC 
Created attachment 287392 [details] [review]
keyboard: Don't allow moving forward without an input source

Disable the Next button if no input source has been selected in the
chooser.
Comment 3 Matthias Clasen 2014-10-09 13:52:15 UTC 
Review of attachment 287391 [details] [review]:

of course
Comment 4 Matthias Clasen 2014-10-09 13:52:41 UTC 
Review of attachment 287392 [details] [review]:

ok
Comment 5 Rui Matos 2014-10-09 13:54:40 UTC 
Attachment 287391 [details] pushed as 2ae64f8 - CcInputChooser: avoid crashing when no input source is set
Attachment 287392 [details] pushed as 34b63df - keyboard: Don't allow moving forward without an input source