After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737487 - h264parse: sets parsed=true on output even in passthrough mode
h264parse: sets parsed=true on output even in passthrough mode
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-27 15:56 UTC by Matej Knopp
Modified: 2018-11-03 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matej Knopp 2014-09-27 15:56:13 UTC 
This doesn't seem right. Just because both input and output are in same format, the parser should claim that it has parsed the input and then enable passthrough.

In may case matroskademux output AVC H.264 (unparsed), decoder requires AVC with parsed=true and parser just  appends parsed=true to the caps without even looking at the stream.
Comment 1 Nicolas Dufresne (ndufresne) 2014-10-02 13:39:31 UTC 
Does this lead to a failure ? If so, could you explain ?
Comment 2 Matej Knopp 2014-10-02 20:10:18 UTC 
IIRC width, height, framerate are missing from caps if not provided from upstream. 

The buffers might also not be split properly on AU boundaries. Just because the upstream says alignment=au, I don't think the parser should blindly trust it.
Comment 3 Sebastian Dröge (slomo) 2014-10-03 06:43:33 UTC 
Yes, in passthrough mode h264parse does not extract anything... so should only really enable it if upstream already provides all possible information. Currently it enables it too often.
Comment 4 Tim-Philipp Müller 2014-10-03 07:22:34 UTC 
And keyframes may not be flagged properly.
Comment 5 Matej Knopp 2014-10-03 13:11:12 UTC 
Right. Completely forgot about this. Actually the keyframes was my biggest issue. I remuxed one file with mkvtoolnix and for some reason no buffers were flagged as keyframes. I have also seen such videos in the wild. 

I think the default behavior should change. Unless there is parsed=true in input caps the parser should never be in passthrough mode.
Comment 6 Sebastian Dröge (slomo) 2014-10-05 18:58:28 UTC 
Agreed, yes. And parsed=True should be accordingly defined :)
Comment 7 GStreamer system administrator 2018-11-03 13:26:51 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/176.