After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737476 - dbusservice: Force Position to be int64
dbusservice: Force Position to be int64
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-27 11:27 UTC by Jens Georg
Modified: 2014-09-29 17:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dbusservice: Force Position to be int64 (1.15 KB, patch)
2014-09-27 11:27 UTC, Jens Georg 		accepted-commit_now Details | Review
dbusservice: Force Position to be int64 (1.28 KB, patch)
2014-09-28 11:11 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2014-09-27 11:27:44 UTC 
Seems to work by accident sometimes, sometimes it's type is "i". "Strongly
typed D-Bus peers" such as Rygel's MRPIS plugin don't really like that.
Comment 1 Jens Georg 2014-09-27 11:27:46 UTC 
Created attachment 287242 [details] [review]
dbusservice: Force Position to be int64

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 2 Bastien Nocera 2014-09-27 11:34:47 UTC 
Review of attachment 287242 [details] [review]:

Looks good, but remove the signed-of-by, and mention the warning that it causes in the commit log.
Comment 3 Jens Georg 2014-09-28 11:11:44 UTC 
Created attachment 287285 [details] [review]
dbusservice: Force Position to be int64

Fixes type mismatch issue with Rygel/GIO:

(lt-rygel:21424): GLib-GIO-WARNING **: Received property Position with type i
does not match expected type x in the expected interface
Comment 4 Bastien Nocera 2014-09-28 14:05:30 UTC 
Review of attachment 287285 [details] [review]:

Please commit to all the appropriate branches all the way down to gnome-3-8.
Comment 5 Jens Georg 2014-09-29 17:37:08 UTC 
Attachment 287285 [details] pushed as 3f48c7a - dbusservice: Force Position to be int64