GNOME Bugzilla – Bug 737457
Esc key doesnt finish the alt + tab menu anymore [due to alternate tab extension]
Last modified: 2014-09-29 13:32:35 UTC
Pressing Escape key in alt + tab combined key doesn't exit from the app select menu. It did in earlyer gnome shell versions and it was really useful feature.
still works here. the right component for this is gnome-shell, where the alt-tab feature is implemented
I can't reproduce the issue either - are you using any extensions that could interfere with the normal shell behavior? Maybe there's something useful in the logs (something like "journalctl _COMM=gnome-session -b" on systemd systems)?
@Florian You are right, it was an alternate tab issue. I have disabled it and esc key works again. Thank you and sorry.
Not a shell issue but alternate tab extension issue.
(In reply to comment #4) > Not a shell issue but alternate tab extension issue. Not so quick - the alternate tab extension is in the set of extensions we support officially, so this *is* our bug. I've been able to reproduce the issue now, patch no its way ...
Created attachment 287238 [details] [review] alternateTab: Fix Escape not dismissing popup Since shell commit dd85670f8b25, the handler got a return value to determine whether Escape should be handled automatically; we do want this for the window switcher, so add an appropriate return value to restore the expected behavior.
Created attachment 287239 [details] [review] alternateTab: Remove _initialSelection injection Since shell commit 2b1077aaa169, the implementation in the SwitcherPopup base class already works as expected.
Created attachment 287240 [details] [review] extension: Reuse original handler in keyPressHandler injection We do need to inject our own handler to treat application-switch actions the same way as the corresponding window-switch ones; we can actually express exactly this without re-implementing the entire function, by calling the original handler with a tweaked action parameter - the resulting code is not only more concise, but should also be a bit more robust against changes in core.
Comment on attachment 287238 [details] [review] alternateTab: Fix Escape not dismissing popup Attachment 287238 [details] pushed as 0dd5b52 - alternateTab: Fix Escape not dismissing popup Pushing the actual fix, as it's straight-forward.
Comment on attachment 287239 [details] [review] alternateTab: Remove _initialSelection injection Attachment 287239 [details] pushed as 687ea92 - alternateTab: Remove _initialSelection injection ... and so is this one
Thank you very much. This is the only extension I used.
Review of attachment 287240 [details] [review]: Looks much better. What's the point of this extension though? People can achieve all this by changing shortcuts nowadays.
(In reply to comment #12) > What's the point of this extension though? Classic mode :-(
Attachment 287240 [details] pushed as d4ca2ae - extension: Reuse original handler in keyPressHandler injection