After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737455 - aacparse: declare Converter capability in metadata
aacparse: declare Converter capability in metadata
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 737396
Blocks:
 
 
Reported: 2014-09-26 17:38 UTC by Matej Knopp
Modified: 2018-11-03 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.02 KB, patch)
2014-09-26 17:38 UTC, Matej Knopp 		reviewed Details | Review

Description Matej Knopp 2014-09-26 17:38:19 UTC 
Created attachment 287200 [details] [review]
Patch

Otherwise decodebin doesn't know the parser can convert and it will not attempt to filter its srcpad
Comment 1 Sebastian Dröge (slomo) 2014-09-27 09:57:57 UTC 
Comment on attachment 287200 [details] [review]
Patch

The problem here is that decodebin assumes that the parser can convert between all of the formats it can support. This is not true for aacparse (yet) and can break negotiation

Of course the code in decodebin already breaks negotiation in other ways so we probably have to fix that anyway :)
Comment 2 Matej Knopp 2014-09-27 13:06:14 UTC 
I thought gst_aac_parse_sink_getcaps would take care of that.

Anyway, I do have some code that can get raw data from loas frames if anyone is interested, but If I understand correctly the converter should also be able to convert to loas (that sounds like quite a lot more work).
Comment 3 Duncan Palmer 2015-01-01 03:59:03 UTC 
Sebastian, regarding your comment, the opposite is also true; if aacparse is not marked as a Converter, decodebin can't construct a pipeline where stream format conversion is required.

Mind you, even when aacparse is marked as a Converter, it can't construct the following pipeline, as decodebin configures the capsfilter to allow raw.

demux -(raw)-> aacparse -(adts)-> capsfilter -(adts)-> decoder
Comment 4 Sebastian Dröge (slomo) 2015-01-08 12:47:03 UTC 
aacparse would need to do negotiation with downstream like h264parse does, i.e. prefer the order of downstream instead of doing passthrough if possible. Then the above pipeline should work.
Comment 5 GStreamer system administrator 2018-11-03 14:54:26 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/130.