After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737434 - keyboard: Add back the gtk+ IM module handling
keyboard: Add back the gtk+ IM module handling
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-26 14:12 UTC by Rui Matos
Modified: 2014-09-26 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Add back the gtk+ IM module handling (3.58 KB, patch)
2014-09-26 14:12 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2014-09-26 14:12:37 UTC 
Jasper prefers not to put this in the shell and since this is not
critical to the input source switching itself, I agree that leaving it
in g-s-d makes more sense.
Comment 1 Rui Matos 2014-09-26 14:12:39 UTC 
Created attachment 287160 [details] [review]
keyboard: Add back the gtk+ IM module handling

This shouldn't have been removed in commit
326ee9f9a102a58941473e08fbe6221e70369f7f.
Comment 2 Bastien Nocera 2014-09-26 14:32:11 UTC 
Review of attachment 287160 [details] [review]:

Sure.
Comment 3 Rui Matos 2014-09-26 14:42:10 UTC 
Attachment 287160 [details] pushed as 390ba58 - keyboard: Add back the gtk+ IM module handling
Comment 4 Jasper St. Pierre (not reading bugmail) 2014-09-26 14:56:22 UTC 
I'd also prefer if the ibus-daemon spawning was done in g-s-d as well.
Comment 5 Rui Matos 2014-09-26 15:31:54 UTC 
(In reply to comment #4)
> I'd also prefer if the ibus-daemon spawning was done in g-s-d as well.

I don't agree with this one because the code to spawn it is basically a Gio.Subprocess.new() which doesn't block us or anything. But then we need to handle re-spawning it when we get disconnected and that means that we need to connect in the first place. Right now, g-s-d doesn't need to be connected to ibus-daemon at all and gnome-shell already needs to be connected in any case, so moving the spawning to g-s-d means removing a single simple call from gnome-shell and adding dozens of lines of C code and a dependency on libibus to g-s-d. I don't think it's worth it.