After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737387 - gnome clocks search provider strangeness
gnome clocks search provider strangeness
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
: 753322 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-09-25 20:16 UTC by Ryan Lerch
Modified: 2016-05-05 02:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
search-provider: rewrite to be stateless (6.93 KB, patch)
2016-05-02 06:42 UTC, Cosimo Cecchi
committed Details | Review

Description Ryan Lerch 2014-09-25 20:16:46 UTC
Hi,

I have hit a couple of issues with the gnome clocks search provider. Not sure if they are related, but if not, i can file seperate bugs later.

First, if i type too fast, the search provider does not seem to register, and no results are found. It is not until I either delete a character in the search (or add another character) until the search is shown. Here is a video of this in action:

https://www.youtube.com/watch?v=JXyLVlS_nkI

Also, after this, i searched for something else, (gpick) and after deleting a few letters of this search, the search result for the first video was then shown:

https://www.youtube.com/watch?v=Z_mBZ9mkW_Y
Comment 1 Cosimo Cecchi 2016-05-02 06:39:15 UTC
*** Bug 753322 has been marked as a duplicate of this bug. ***
Comment 2 Cosimo Cecchi 2016-05-02 06:42:46 UTC
Created attachment 327129 [details] [review]
search-provider: rewrite to be stateless

Currently the search provider carries state between searches. This is
a source of bugs, as sometimes search results are not consistent or not
returned at all for certain searches.

This commit uses gweather_location_serialize()/deserialize() to make
the provider stateless.
Comment 3 Paolo Borelli 2016-05-03 16:24:11 UTC
Review of attachment 327129 [details] [review]:

Thanks, yes, I guess this is the best way to shield ourselves from the shell implementation.
Comment 4 Cosimo Cecchi 2016-05-05 02:38:22 UTC
Thanks, pushed to master

Attachment 327129 [details] pushed as c6681f8 - search-provider: rewrite to be stateless