GNOME Bugzilla – Bug 737340
theme_text_color is no longer in gtk 3.14
Last modified: 2014-10-22 15:49:28 UTC
Hi, "theme_text_color", used to style several widgets, does no longer exist in default gtk 3.14 theme. Using Adwaita dark variant then results in unreadable dark-on-dark text in the messages pane e-table. Regards, Jérémy.
BTW, same problem in libgtkhtml-editor 4.0
And replacing "theme_text_color" by "theme_fg_color" in both fixes the messages list and the composer colors.
Created attachment 287062 [details] [review] evolution patch
Created attachment 287063 [details] [review] gtkhtml patch
it is also interesting to check how that change has impacted other software http://codesearch.debian.net/search?q=theme_text_color it seems it only affects evolution, gtkhtml, almanah and gnome-clocks.
These patches would require bumping the GTK+ dependency to 3.14 in configure.ac. Not worth it for this, imo. I suggest using GTK_CHECK_VERSION(3,14,0) macros to work around GTK-3.14's backward-compatibility break.
On the contrary, fg_color == text_color everywhere the comparison makes sense in the default gtk3 theme, so this change would loosen dependency instead of tightening it ! https://git.gnome.org/browse/gtk+/tree/gtk/resources/theme/gtk-default.css?h=gtk-3-12 https://git.gnome.org/browse/gtk+/tree/gtk/gtk-default.css?h=gtk-3-6
Created attachment 287211 [details] [review] theme_text_color updated to theme_fg_color in Almanah Thanks for pointing it. Looks good to me.
Review of attachment 287211 [details] [review]: Commited!
*** Bug 737417 has been marked as a duplicate of this bug. ***
Thanks for a bug report and patches. The e_utils_get_theme_color/_color() functions allow defining fallback color names. I'll update your patches and commit them.
With the patch applied I still have got black text on dark background when composing a new message in evolution. Colors in the message list are fixed though.
I made a little change in Jérémy's GtkHTML patch. Note the composer is affected only in evolution 3.12.x, not 3.13.4+. Created commit 6af2ade in evo master (3.13.7+) [1] Created commit 9c6219c in evo evolution-3-12 (3.12.7+) Created commit 5cfa2c8 in gtkhtml master (4.9.1+) [2] Created commit 19d6e22 in gtkthml gnome-3-12 (4.8.5+) [1] https://git.gnome.org/browse/evolution/commit/?id=6af2ade [2] https://git.gnome.org/browse/gtkhtml/commit?id=5cfa2c8
(In reply to comment #12) > With the patch applied I still have got black text on dark background when > composing a new message in evolution. > Colors in the message list are fixed though. I verified the committed fix in a gtkhtml-editor-test and the text color is white there, on a dark (almost black) background.
*** Bug 738390 has been marked as a duplicate of this bug. ***
*** Bug 738389 has been marked as a duplicate of this bug. ***
*** Bug 738371 has been marked as a duplicate of this bug. ***