After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737296 - Error on help page "Save a copy of an annotated PDF"
Error on help page "Save a copy of an annotated PDF"
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: User documentation
3.14.x
Other All
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-24 22:15 UTC by David King
Modified: 2014-11-27 18:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
removed Okular from save-annotations page (1.63 KB, patch)
2014-09-25 07:37 UTC, Shobha
needs-work Details | Review
removed Okular from save-annotations page (2.59 KB, patch)
2014-11-27 12:34 UTC, Shobha
committed Details | Review

Description David King 2014-09-24 22:15:07 UTC
As reported by Torokhov Sergey, Okular has supported annotations since version 0.15 (2012), so the mention of Okular not supporting annotations should be removed from annotations-save.page.

https://mail.gnome.org/archives/docs-feedback/2014-September/msg00027.html
Comment 1 Shobha 2014-09-25 07:37:00 UTC
Created attachment 287046 [details] [review]
removed Okular from save-annotations page

I actually could not update the version from "0.1" to the present as I could not make out what is it:
 
 <revision pkgversion="3.2" version="0.1" date="2011-09-05" status="final"/>
 <revision pkgversion="3.14" version="0.1" date="2014-09-25" status="review"/>

Please review and help thanks
Comment 2 David King 2014-09-26 12:17:48 UTC
Review of attachment 287046 [details] [review]:

I seem to remember (when looking at this earlier) that the rest of the page was out of date. I think that saving the file (step 1), in now done by clicking the "menu button" and clicking "Save a Copy…"

::: help/C/annotations-save.page
@@ +9,2 @@
     <revision pkgversion="3.2" version="0.1" date="2011-09-05" status="final"/>
+    <revision pkgversion="3.14" version="0.1" date="2014-09-25" status="review"/>

The version attributes are weird (as you pointed out). I think that it is best to remove them entirely, leaving only pkgversion.

@@ +39,3 @@
    </steps>
    <p>
+   Annotations are added according to the PDF specification. Therefore, most PDF readers should be able to read them. Adobe Reader is known to work.

Looks fine, although can you break the line (as it extends past 79 characters)?
Comment 3 Shobha 2014-11-27 12:34:21 UTC
Created attachment 291636 [details] [review]
removed Okular from save-annotations page

please see patch corrected as per the reviews. 
sorry for the delay!!
thanks
Comment 4 David King 2014-11-27 13:49:17 UTC
Review of attachment 291636 [details] [review]:

Looks good to me.

::: help/C/annotations-save.page
@@ +30,3 @@
    <item>
      <p>
+      Click <guiseq><gui>Menu button</gui><gui>Save a Copy...</gui></guiseq>

Just change the three dots "..." to an ellipsis "…".
Comment 5 Shobha 2014-11-27 18:42:39 UTC
after the changing the dots to an ellipsis pushed the patch to the master in the commit: c45400e85e1845026d7b5f3788d4f0e9632ed85b

thanks!!