After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737246 - taglist not send to down stream if all the frame corrupted
taglist not send to down stream if all the frame corrupted
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.2.3
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-24 09:23 UTC by Jian Li
Modified: 2018-11-03 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.17 KB, patch)
2014-09-24 09:24 UTC, Jian Li 		none Details | Review

Description Jian Li 2014-09-24 09:23:16 UTC 
I found in audiodecoder and videodecoder base, taglist only be sent to downstream when successfully decoded one frame.
But for some corrupted streams, all the frames maybe corrupted, decoder can get one valid frame util EOS. In this case, taglist will be missing in the pipeline, then application can get the track info from playbin.

I think it should check if there is still tags_changed when received EOS and drained all the data, if yes, send this tags to downstream.

A patch is attached, please check it.
Comment 1 Jian Li 2014-09-24 09:24:12 UTC 
Created attachment 286960 [details] [review]
patch
Comment 2 GStreamer system administrator 2018-11-03 11:31:16 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/132.