GNOME Bugzilla – Bug 737211
Use the new API for handling RTL icons and margin
Last modified: 2014-10-07 22:46:41 UTC
The patch for RTL icons very important, I'm sorry I'm so late, but now RTL users see 'fuzzy' icon instead of the next/previous icons. It bump the GTK+'s version to 3.13.4.
Created attachment 286918 [details] [review] build: Bump required GTK+ version
Created attachment 286919 [details] [review] ev-history-action: Use the new support for RTL icons in GtkIconTheme
Created attachment 286920 [details] [review] ev-toolbar: Use margin-end instead of margin-right
Looks good to me, but could we use GTK_CHECK_VERSION instead of bumping GTK+ requirements only for this?
(In reply to comment #4) > Looks good to me, but could we use GTK_CHECK_VERSION instead of bumping GTK+ > requirements only for this? Because of gestures, Evince already requires GTK+ 3.14, even if configure.ac does not say so. See Bug 737926
Review of attachment 286918 [details] [review]: Pushed as 18ecf7f - build: Bump required GTK+ version
Review of attachment 286919 [details] [review]: Pushed as 72ce19e - ev-history-action: Use the new support for RTL icons in GtkIconTheme
Review of attachment 286920 [details] [review]: Pushed as 0c9816c - ev-toolbar: Use margin-end instead of margin-right
(In reply to comment #6) > Review of attachment 286918 [details] [review]: > > Pushed as 18ecf7f - build: Bump required GTK+ version Did Carlos approve this one? AFAIR, dependencies should be from stable releases rather than unstable ones.
(In reply to comment #9) > (In reply to comment #6) > > Review of attachment 286918 [details] [review] [details]: > > > > Pushed as 18ecf7f - build: Bump required GTK+ version > > Did Carlos approve this one? > > AFAIR, dependencies should be from stable releases rather than unstable ones. There isn't unstable branch yet. Also, I wants this patches for the gnome-3-14 anyway. For the 18ecf7f patch, since you mention we already de-facto depns on GTK+ 3.14, I guesse it ok to push this patch.
I am not the maintainer. Also, your patch defines GTK 3.13.4, not 3.14 (which was my point wrt stable releases).
I know you are not the maintainer, but you said something right. I not think it really matter if my patch defines 3.13.4 or 3.14.0. If you care about this, you can to bump the version to 3.14.0.
Yosef, thanks for the patches, but please, do not push patches unreviewed, wait until flag is changed to accepted-commit_now, you know you can ping me on IRC. I agree with Germán, we should depend on GTK+ 3.14, so please push a follow up patch to bump requirements to 3.14.
Carlos, sorry about this, I thought you said LGTM in comment #4 it like accepet-commit_now. I pushed a patch to bump GTK+ to 3.14.0.