After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737207 - Bring clutter-gtkmm up to date
Bring clutter-gtkmm up to date
Status: RESOLVED FIXED
Product: clutter-gtkmm
Classification: Other
Component: general
git master
Other Mac OS
: Normal normal
: ---
Assigned To: clutter-gtkmm-maint
clutter-gtkmm-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-23 18:35 UTC by Juan R. Garcia Blanco
Modified: 2014-10-12 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Regenerate clutter-gtk_signals.defs (32.43 KB, patch)
2014-09-23 18:40 UTC, Juan R. Garcia Blanco 		none Details | Review
Wrap Embed::use-layout"size property (942 bytes, patch)
2014-09-23 19:51 UTC, Juan R. Garcia Blanco 		none Details | Review
Wrap GtkClutterActor (4.47 KB, patch)
2014-09-23 19:54 UTC, Juan R. Garcia Blanco 		none Details | Review
Wrap GtkClutterWindow (5.77 KB, patch)
2014-09-23 20:40 UTC, Juan R. Garcia Blanco 		none Details | Review
Wrap missing methods in Embed. (1.83 KB, patch)
2014-09-24 17:57 UTC, Juan R. Garcia Blanco 		none Details | Review
Wrap Embed as GTKOBJECT (864 bytes, patch)
2014-09-24 18:03 UTC, Juan R. Garcia Blanco 		none Details | Review

Description Juan R. Garcia Blanco 2014-09-23 18:35:36 UTC 
I think there are a few issues with this package:
- GtkClutterActor is not wrapped.
- GtkClutterWindow is not wrapped.
- clutter-gtk_signals.defs is outdated, which causes gmmproc to output that a lot of properties are not wrapped.
Comment 1 Juan R. Garcia Blanco 2014-09-23 18:40:13 UTC 
Created attachment 286914 [details] [review]
Regenerate clutter-gtk_signals.defs
Comment 2 Juan R. Garcia Blanco 2014-09-23 19:51:28 UTC 
Created attachment 286923 [details] [review]
Wrap Embed::use-layout"size property
Comment 3 Juan R. Garcia Blanco 2014-09-23 19:54:20 UTC 
Created attachment 286924 [details] [review]
Wrap GtkClutterActor
Comment 4 Juan R. Garcia Blanco 2014-09-23 20:40:03 UTC 
Created attachment 286932 [details] [review]
Wrap GtkClutterWindow
Comment 5 Juan R. Garcia Blanco 2014-09-24 17:57:50 UTC 
Created attachment 286998 [details] [review]
Wrap missing methods in Embed.
Comment 6 Juan R. Garcia Blanco 2014-09-24 18:03:58 UTC 
Created attachment 286999 [details] [review]
Wrap Embed as GTKOBJECT
Comment 7 Murray Cumming 2014-10-01 07:39:35 UTC 
Review of attachment 286998 [details] [review]:

We generally add "== true" for simple setters.
Comment 8 Murray Cumming 2014-10-01 07:47:15 UTC 
These all look great to me. Please go ahead. And I think you can safely just make any commits that you like. There doesn't seem to be any active maintainer, so I guess you could even make a release if you like.
Comment 9 Juan R. Garcia Blanco 2014-10-01 20:15:40 UTC 
Thank you! I'll keep the bug report open until I make a release containing these updates, if you agree.

I have a few questions:
- How can I discover which library version this package depends on? I mean, currently it requires clutter-gtk >=0.91.8 (a few days ago clutter-gtk 1.6.1 was released); however, I do not know how can I be sure there are no new symbols in more recent versions.
I can do this by reverting my clutter-gtk installation and checking if clutter-gtkmm builds... I just wonder if there is a simpler way.
- Should I bump the package's version number? I mean, to match the latest clutter-gtk released version number. I'm not referring here to the so version, which I know I need to update.