After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737185 - Create a smaller disk image for the hwtest tree
Create a smaller disk image for the hwtest tree
Status: RESOLVED FIXED
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Continuous maintainer(s)
GNOME Continuous maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-23 14:30 UTC by Owen Taylor
Modified: 2014-09-25 03:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Create a smaller disk image for the hwtest tree (2.28 KB, patch)
2014-09-23 14:30 UTC, Owen Taylor
reviewed Details | Review
Create a smaller disk image for the hwtest tree (2.32 KB, patch)
2014-09-23 18:54 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2014-09-23 14:30:31 UTC
Since the hwtest tree doesn't include the desktop and is considerably
smaller than the other trees, and since one of the uses of the tree
is writing to a USB disk for installation, build only a 4GB image
for the hwtest tree.
Comment 1 Owen Taylor 2014-09-23 14:30:34 UTC
Created attachment 286881 [details] [review]
Create a smaller disk image for the hwtest tree
Comment 2 Colin Walters 2014-09-23 15:51:43 UTC
Review of attachment 286881 [details] [review]:

::: src/js/tasks/task-builddisks.js
@@ +113,3 @@
             } else {
+                // create a smaller disk for the hwtest image to facilitate writing to a thumbdrive
+                var sizeMB = JSUtil.stringEndswith(targetName, '-hwtest') ? 4 * 1024 : 8 * 1024;

We have a default both here and in in libqa.js, can we have just one?  So only pass params if -hwtest?
Comment 3 Owen Taylor 2014-09-23 18:54:24 UTC
Created attachment 286915 [details] [review]
Create a smaller disk image for the hwtest tree

Since the hwtest tree doesn't include the desktop and is considerably
smaller than the other trees, and since one of the uses of the tree
is writing to a USB disk for installation, build only a 4GB image
for the hwtest tree.
Comment 4 Colin Walters 2014-09-23 20:27:19 UTC
Review of attachment 286915 [details] [review]:

Yep.
Comment 5 Owen Taylor 2014-09-25 03:13:26 UTC
Attachment 286915 [details] pushed as 298719d - Create a smaller disk image for the hwtest tree