After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737177 - Inline reply composer does not show Subject field
Inline reply composer does not show Subject field
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: composer
master
Other Linux
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: 795219
Blocks:
 
 
Reported: 2014-09-23 13:34 UTC by Davi
Modified: 2019-06-22 05:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Davi 2014-09-23 13:34:26 UTC
I was trying to reply to a mailing list with "Remove" subject, but I could not change the subject of the reply message because no Subject field was present (event after clicking the destination address to show cc and cco fields). Detaching the composer to a new window shows the Subject field properly.

I'm using geary-0.8.0-x86_64 in Arch Linux.
Comment 1 Jim Nelson 2014-09-23 19:34:54 UTC
This is intentional and a design choice.  We wanted to keep the inline composer's chrome to a minimum, otherwise it will fill too much of the main window.

However, that design choice was made when the inline composer was still in its infancy.  Robert's made some nice improvements to how it sizes itself inline.  Perhaps it's time to revisit the question.
Comment 2 Davi 2014-09-23 20:50:32 UTC
The rationale is somewhat understandable. It causes confusion though. Maybe clicking in the destination address to expand it should detach the composer directly?
Comment 3 Robert Schroll 2014-09-23 21:11:30 UTC
I had an idea about this, but I don't think I ever made a bug for it.  So I'll just post it here.

In the detached composer, the subject is duplicated in the header and the subject entry.  So why not move the subject entry to the header?  My idea is that it'd be a label until you click it, at which point it becomes an entry.  (We'd want some trickery to ensure that you can still drag the window; I don't know how hard this would be.)

And if we're doing that in the detached composer, it'd be natural to make it happen in the inline composer as well.  It wouldn't take up any more space than it currently does, but it'd use the middle of the headerbar, which is currently blank.

The inline-compact mode (the one with the recipients listed) would remain unchanged.  Perhaps we should add the subject to the tooltip.

I'm not sure what to do about the inline-new mode.  We could do it there as well, but that'd disrupt the recipients-subject-body sequence that everyone's used to.  (Although, we could set the tab order that way.)  But since space is not so restricted there, and because the subject has to be set, keeping a separate entry may be the way to go.
Comment 4 Davi 2014-09-24 00:59:02 UTC
What about using an expander for the extra fields? This way the space could be easily reclaimed. It could also work with a popover shown when the destination is clicked.

IMHO, I don't think repeating the subject in the detached composer is a big issue. Maybe the header could show the conversation title (empty for new message), instead of the subject?

P.S.: I'm just trying to contribute some ideas. I'm sorry for being intrusive! Please, feel free to ignore anything I say and to tell me to shut up anytime!
Comment 5 Robert Schroll 2014-09-24 17:10:54 UTC
(In reply to comment #4)
> What about using an expander for the extra fields? This way the space could be
> easily reclaimed. It could also work with a popover shown when the destination
> is clicked.

I'm don't think I understand.  Where would this expander go?  Perhaps you could make a mock-up.

> P.S.: I'm just trying to contribute some ideas. I'm sorry for being intrusive!

Not at all.  There's not a whole lot of presidence for how conversation-focused mail clients should work, so we're groping around a bit.  The more ideas that get thrown out, the higher the chance that we stumble on the right one.
Comment 6 Davi 2014-09-24 17:46:00 UTC
(In reply to comment #5)
> 
> I'm don't think I understand.  Where would this expander go?  Perhaps you could
> make a mock-up.
> 

Let me try some ascii "art".

First, let me draw the current layout so you can maybe understand my notation. Initially, when clicking the reply button, you have this inline composer (more or less):

-----------------------------------------------------------------------------
[attach] destination (unrelieved button)              [send] | detach discard
-----------------------------------------------------------------------------
                                  (rich text tools)
-----------------------------------------------------------------------------
                                    (message area)
-----------------------------------------------------------------------------

when you click the destination button, it leaves the header and three rows with to: cc: and cco: entries are added below:

-----------------------------------------------------------------------------
[attach]                                              [send] | detach discard
-----------------------------------------------------------------------------
to: [                                                                       ]
cc: [                                                                       ]
cco:[                                                                       ]
                                  (rich text tools)
-----------------------------------------------------------------------------
                                    (message area)
-----------------------------------------------------------------------------

Now, my idea is to have an initial composer slightly different, using an expander instead of a button:

-----------------------------------------------------------------------------
[attach] > (expander button) destination              [send] | detach discard
-----------------------------------------------------------------------------
                                  (rich text tools)
-----------------------------------------------------------------------------
                                    (message area)
-----------------------------------------------------------------------------

when you click the expander button, the extra entries are shown:

-----------------------------------------------------------------------------
[attach] v (expanded expander button)                 [send] | detach discard
-----------------------------------------------------------------------------
to: [                                                                       ]
cc: [                                                                       ]
cco:[                                                                       ]
sub:[                                                                       ]
                                  (rich text tools)
-----------------------------------------------------------------------------
                                    (message area)
-----------------------------------------------------------------------------

it is possible then to edit the entries. If you need more space for the message, though, you can collapse the expander again and go back to the previous ui state. You can always check the entries again by expanding and collapsing.

Note: I do not know if this is even possible to do with the ui toolkit.


> 
> Not at all.  There's not a whole lot of presidence for how conversation-focused
> mail clients should work, so we're groping around a bit.  The more ideas that
> get thrown out, the higher the chance that we stumble on the right one.

Glad to hear it. I hope I can help then.
Comment 7 Jim Nelson 2014-09-24 20:17:31 UTC
What you're suggesting could be done with GtkRevealer.  Or, we could simply punt and add Subject to the inline composer, displayed when the user clicks on the Recipients' button when collapsed.  I feel better about doing this now with the scrollbar work Robert got in before we shipped, because the composer is now much more intelligent about how it uses space.

One proviso to your suggestion, Davi, is that when the fields are revealed, they need to stay revealed.  We encountered this issue when working on the inline composer.  If the user begins editing those fields, allowing them to collapse/hide them opens up a can of worms UI-wise.
Comment 8 Federico Bruni 2018-01-12 16:15:47 UTC
I agree with Davi that the Subject field should be editable also in inline mode, when the user clicks on the recipient label (exiting the compact mode).

By the way, I see that the inline composer, even in compact mode, always shows the Cc field even if it's empty. This is a waste of space.
Comment 9 Michael Gratton 2019-06-22 05:42:47 UTC
Closing in favour of https://gitlab.gnome.org/GNOME/geary/issues/471