GNOME Bugzilla – Bug 737174
No way to build against qt4 if both versions are installed
Last modified: 2015-05-31 12:52:42 UTC
As configure is automagically switching to qt5 when both are installed, there is no way to force a build against qt4 when qt5 is present. https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies Thanks
(In reply to comment #0) > As configure is automagically switching to qt5 when both are installed, there > is no way to force a build against qt4 when qt5 is present. > https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies Under what circumstances would you want to use Qt4 when you have Qt5?
Well, it's a bit of making it more predictable. I mean, currently, most people will have libmediaart compiled against qt4 because qt5 landed the tree few days ago but, as soon as people starts installing qt5 also, libmediaart will be compiled against qt5 as soon as people tries to recompile it. I guess that qt5 support is preferred for libmediaart? In that case maybe we could force that dependency and disable qt4 support completely (maybe some people will disagree if qt5 is pulled only by this at this stage... but I guess qt5 will be used by more and more apps and this shouldn't be a major issue)
(In reply to comment #2) > Well, it's a bit of making it more predictable. I mean, currently, most people > will have libmediaart compiled against qt4 because qt5 landed the tree few days > ago but, as soon as people starts installing qt5 also, libmediaart will be > compiled against qt5 as soon as people tries to recompile it. I guess it depends on what is installed in $prefix, but yea. > I guess that qt5 support is preferred for libmediaart? In that case maybe we There is no preference, basically, we just support both versions to work in both cases. > could force that dependency and disable qt4 support completely (maybe some > people will disagree if qt5 is pulled only by this at this stage... but I guess > qt5 will be used by more and more apps and this shouldn't be a major issue) Some configure option for this could be added indeed - fancy writing a patch, should be quite simple to do?
Created attachment 289820 [details] [review] libmediaart-qt-version-automagic-fix.patch Adds optional configure flag "--with-qt-version=<4|5>" that may be used to enforce qt 4.x or qt 5.x version.
Comment on attachment 289820 [details] [review] libmediaart-qt-version-automagic-fix.patch Looks good to me, please go ahead and commit. If you can't I will. Thanks again!
(In reply to comment #5) > (From update of attachment 289820 [details] [review]) > Looks good to me, please go ahead and commit. If you can't I will. Thanks > again! Martyn, could you go ahead and commit it?
(In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 289820 [details] [review] [details]) > > Looks good to me, please go ahead and commit. If you can't I will. Thanks > > again! > > Martyn, could you go ahead and commit it? Sure, see comment #5 ;)
I am not sure why is this still in NEEDINFO status :/, anyway, would be nice if someone with enough permissions could finally commit it :) Thanks
Review of attachment 289820 [details] [review]: Committed the patch, thanks! :)