GNOME Bugzilla – Bug 737145
[PATCH] Remove Strategy enum.
Last modified: 2014-09-25 03:14:35 UTC
Created attachment 286846 [details] [review] Remove Strategy enum. Knowing level is sufficient to decide what to do. Choosing a strategy at start and at an other place doing the job is the best way to make errors. Let’s remove Strategy enum.
Review of attachment 286846 [details] [review]: OK, but please say "difficulty_level" instead of simply "level" since that has nearly the same meaning as "depth" and would be quite confusing to have in the signature otherwise.
Created attachment 286906 [details] [review] Remove the Strategy enum.
This doesn't apply on master. :( I think you've probably based it on the 3.14 branch again.
Created attachment 287010 [details] [review] Remove the Strategy enum. This batch was build on top of the “Faster history” série, but now it can’t apply anymore because of the last threading patch. ^^ Here is an update. By the way, I don’t understand the: if (depth == 0 || !move_pending) return calculate_heuristic (g); Is it really completely necessary to launch calculate_heuristic() if the move has been cancelled?
(In reply to comment #4) > This batch was build on top of the “Faster history” série, but now it can’t > apply anymore because of the last threading patch. ^^ Here is an update. That definitely wasn't the problem; I tried to apply this one first, figuring I'd rather fix a small conflict in my own patch than in yours. > By the way, I don’t understand the: > if (depth == 0 || !move_pending) > return calculate_heuristic (g); > Is it really completely necessary to launch calculate_heuristic() if the move > has been cancelled? It shouldn't matter what gets returned, or even if we have that check at all.
Attachment 287010 [details] pushed as 9cf1e50 - Remove the Strategy enum.