After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737144 - avauddec: keep draining buffers from libav until libav says so
avauddec: keep draining buffers from libav until libav says so
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 1.4.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-22 20:59 UTC by Aleix Conchillo Flaqué
Modified: 2014-09-24 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
drain all samples from libav (4.26 KB, patch)
2014-09-22 21:04 UTC, Aleix Conchillo Flaqué 		committed Details | Review

Description Aleix Conchillo Flaqué 2014-09-22 20:59:40 UTC 
Similar to bug 736515 but for the audio decoder. We have to keep draining buffers until libav tells us instead of a try n times loop.

I have to say that I haven't had any problems with the current code, so this might not for 1.4.3. But I'm not sure, because you might eventually hit the problem.

I initially thought I had the same avviddec problem in avauddec. Then, I realized I had the faad element installed.
Comment 1 Aleix Conchillo Flaqué 2014-09-22 21:04:12 UTC 
Created attachment 286844 [details] [review]
drain all samples from libav
Comment 2 Sebastian Dröge (slomo) 2014-09-23 16:14:43 UTC 
commit 24780708beab26904c04742865e3354ed4718af0
Author: Aleix Conchillo Flaqué <aconchillo@gmail.com>
Date:   Mon Sep 22 14:00:07 2014 -0700

    avauddec: drain samples until libav doesn't have more data
    
    We use have_data (that comes from libav), instead of only trying 10
    times, to know if there are more samples available. The old code was
    machine dependent as different amount of samples could be decoded by
    different type of (more powerful) machines, and 10 times was not always
    sufficient.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=737144