After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737141 - Doesn't load notes in commit message
Doesn't load notes in commit message
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-22 20:02 UTC by Bastien Nocera
Modified: 2014-11-04 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show commit notes (4.13 KB, patch)
2014-11-03 22:02 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
Show commit notes (4.14 KB, patch)
2014-11-03 22:20 UTC, Ignacio Casal Quinteiro (nacho) 		committed Details | Review

Description Bastien Nocera 2014-09-22 20:02:42 UTC 
Somebody got the release number wrong in nautilus-sendto some time ago, and added a note correcting the entry. But it doesn't appear in the git log in gitg:
https://git.gnome.org/browse/nautilus-sendto/commit/?id=ccc8609ca6f645169779344c03e3449b67c4764c
Comment 1 Ignacio Casal Quinteiro (nacho) 2014-09-23 13:38:40 UTC 
The notes api is not even bound. We'd need to first add the proper api to libgit2-glib and then implement the feature.
Comment 2 Ignacio Casal Quinteiro (nacho) 2014-11-03 22:02:28 UTC 
Created attachment 289950 [details] [review]
Show commit notes
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-11-03 22:20:24 UTC 
Created attachment 289951 [details] [review]
Show commit notes
Comment 4 Ignacio Casal Quinteiro (nacho) 2014-11-04 07:36:19 UTC 
Attachment 289951 [details] pushed as a993f23 - Show commit notes
Comment 5 Bastien Nocera 2014-11-04 07:48:19 UTC 
Couldn't build gitg. Is a build requirement bump missing?

make[2]: Entering directory '/home/hadess/Projects/jhbuild/gitg'
  VALAC    libgitg_libgitg_1_0_la_vala.stamp
warning: --save-temps has no effect when -C or --ccode is set
libgitg/gitg-commit.vala:173.9-173.17: error: The type name `Ggit.Note' could not be found
	public Ggit.Note get_note()
	       ^^^^^^^^^
libgitg/gitg-commit.vala:175.3-175.11: error: The type name `Ggit.Note' could not be found
		Ggit.Note note = null;
		^^^^^^^^^
Compilation failed: 2 error(s), 1 warning(s)
Makefile:3811: recipe for target 'libgitg_libgitg_1_0_la_vala.stamp' failed
Comment 6 Ignacio Casal Quinteiro (nacho) 2014-11-04 08:13:25 UTC 
You are right, just pushed the patch to bump the version of libgit2-glib