After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737108 - OpenVPN: Support --float parameter
OpenVPN: Support --float parameter
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
unspecified
Other All
: Normal enhancement
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-22 10:05 UTC by Jan Alexander Steffens (heftig)
Modified: 2015-05-28 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for nm support of openvpn float (5.26 KB, patch)
2015-04-01 01:50 UTC, Scott Howard
none Details | Review
Add checkbox to pass the --float option in OpenVPN (12.57 KB, patch)
2015-04-01 12:07 UTC, Thomas Haller
none Details | Review
Add checkbox to pass the --float option in OpenVPN (13.23 KB, patch)
2015-04-01 12:33 UTC, Thomas Haller
none Details | Review
[PATCH] fix clash in mnemonic keys (F_loat) (1.38 KB, patch)
2015-05-28 06:47 UTC, Jiri Klimes
none Details | Review
[PATCH] support 'float' in nm-import-openvpn script (1.21 KB, patch)
2015-05-28 06:47 UTC, Jiri Klimes
none Details | Review

Description Jan Alexander Steffens (heftig) 2014-09-22 10:05:45 UTC
As of 0.9.10.0 the GUI does not have an option to pass the --float parameter to OpenVPN.
Comment 1 Scott Howard 2015-04-01 01:50:23 UTC
Created attachment 300722 [details] [review]
patch for nm support of openvpn float

an old patch, at least illustrates how it can be done
Comment 3 Thomas Haller 2015-04-01 12:07:17 UTC
Created attachment 300734 [details] [review]
Add checkbox to pass the --float option in OpenVPN

Essentially, --float tells OpenVPN to accept authenticated packets from
any address, not only the address which was specified in the --remote
option. This allows remote peer to change its IP address and/or port
number. This is useful when you are connecting to a peer which holds
a dynamic address such as a dial-in user or DHCP client.

[thaller@redhat.com: rebased on current master]
[thaller@redhat.com: add import/export and tests]

https://mail.gnome.org/archives/networkmanager-list/2010-November/msg00014.html
Comment 4 Thomas Haller 2015-04-01 12:08:18 UTC
the original patch attachment 300722 [details] [review] applies on commit 0cfd6b966c80de0e689badedf9d6ad50dd355e4f.

I rebased it on master, and added test,import and export.
Comment 5 Thomas Haller 2015-04-01 12:33:16 UTC
Created attachment 300739 [details] [review]
Add checkbox to pass the --float option in OpenVPN

Essentially, --float tells OpenVPN to accept authenticated packets from
any address, not only the address which was specified in the --remote
option. This allows remote peer to change its IP address and/or port
number. This is useful when you are connecting to a peer which holds
a dynamic address such as a dial-in user or DHCP client.

[thaller@redhat.com: rebased on current master]
[thaller@redhat.com: add import/export and tests]

https://mail.gnome.org/archives/networkmanager-list/2010-November/msg00014.html
Comment 6 Thomas Haller 2015-04-01 12:34:39 UTC
(In reply to Thomas Haller from comment #5)
> Created attachment 300739 [details] [review] [review]
> Add checkbox to pass the --float option in OpenVPN

hmpf, v1 in attachment 300734 [details] [review] had bugs... v2 here...


AFAIU, --float only has relevance together with --remote. Since there is no UI for --remote, maybe should not have --float there either(?)
Comment 7 Jan Alexander Steffens (heftig) 2015-04-01 19:16:28 UTC
The setting used for --remote is the gateway address; check NM_OPENVPN_KEY_REMOTE.
Comment 8 Jiri Klimes 2015-05-28 06:45:51 UTC
(In reply to Thomas Haller from comment #5)
> Created attachment 300739 [details] [review] [review]
> Add checkbox to pass the --float option in OpenVPN
> 
> Essentially, --float tells OpenVPN to accept authenticated packets from
> any address, not only the address which was specified in the --remote
> option. This allows remote peer to change its IP address and/or port
> number. This is useful when you are connecting to a peer which holds
> a dynamic address such as a dial-in user or DHCP client.
> 
> [thaller@redhat.com: rebased on current master]
> [thaller@redhat.com: add import/export and tests]
> 
> https://mail.gnome.org/archives/networkmanager-list/2010-November/msg00014.
> html

The patch look and work fine for me.

I will just attach a fixup to fix a mnemonics key clash, and addition of 'float' to nm-import-openvpn script.


(In reply to Thomas Haller from comment #6)
> (In reply to Thomas Haller from comment #5)

> AFAIU, --float only has relevance together with --remote. Since there is no
> UI for --remote, maybe should not have --float there either(?)

As Jan says above, '--remote' is the "Gateway" entry and it is mandatory.
Comment 9 Jiri Klimes 2015-05-28 06:47:11 UTC
Created attachment 304125 [details] [review]
[PATCH] fix clash in mnemonic keys (F_loat)
Comment 10 Jiri Klimes 2015-05-28 06:47:56 UTC
Created attachment 304126 [details] [review]
[PATCH] support 'float' in nm-import-openvpn script