After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737088 - User's terminal (unequal gnome-terminal) not supported
User's terminal (unequal gnome-terminal) not supported
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: application
1.4.x
Other Linux
: Normal minor
: 1.4
Assigned To: GNOME Commander maintainer(s)
GNOME Commander maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-21 20:10 UTC by frawoh
Modified: 2014-10-12 18:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description frawoh 2014-09-21 20:10:11 UTC
In the settings of GNOME Commander, there is the option to maintain an user specific terminal [Options (Ctrl+O) ==> Programs ==> Terminal ).
However, this field seems to be ignored...

I use XFCE with xfce4-terminal rather xterm. Both entries doesn't work. On another system, I installed all that terminals as well but also gnome-terminal additionally.
Result: Gnome-terminal always (only) works - it comes up always independent of the setting mentioned above.

I found bugzilla #571495 - it seems there already a coding was suggested. Due to this bug-number, I found function void command_open_terminal (file ./src/gnome-cmd-user-actions.cc). I changed coding there a little bit (and quite unprofessional...) but after that another terminal works now:

void command_open_terminal (GtkMenuItem *menuitem, gpointer not_used)
{
...
[-] if (gnome_execute_terminal_shell (dpath, NULL) == -1)
[+] if (gnome_execute_shell (dpath, "xfce4-terminal") == -1)
...
}
Please note that this only worked with function gnome_execute_shell, not with gnome_execute_terminal_shell... Don't know why...
==> Independent from this, I think it seems to be the relevant function definitely. In the current coding, only the gnome-terminal gets defined due to the second NULL-parameter.
There the terminal (maintained as parameter in the options mentioned above) should be used instead in my eyes.

At any questions please let me know - thanks in advance!
GNOME Commander is my favourite FileManager, but I don't want to install gnome-terminal into my xfce-environment... :-)
Comment 1 Uwe Scholz 2014-09-28 20:14:44 UTC
Thank you for your bug report.

As a workaround this might be a solution. But there should be the possibility to change the terminal in gcmd's options. For the desired feature I'll have to dig a little bit deeper into the code.

Therefore, I'll leave this bug report open as a reminder. Thanks again!
Comment 2 frawoh 2014-10-01 04:20:15 UTC
Hi Uwe,

thanks for your quick response to this!

As you wrote of a "desired feature" and furthermore that "... there should be the possibility to change the terminal in gcmd's options", please note that there *already exists* such an option in the gcmd's seetings [1].

That's why this isn't a "desired feature" in my eyes but a real bug (and if this could get fixed in a V1.4.x-bugrelease instead of new V2.x-version, this would be great :-))

Issue itself isn't critical definitely, but current situation might be confusing. I found some other workarounds of irritated users where they changed the default-terminal in the GNOME-control-center [2]. I tried this as well, but meantime ("GNOME_3-simplification"?!), the terminal can't be changed there anymore. Independent to this, this also would be a workaround only (and therefore I needed to install half of GNOME-environment into my XFCE-environment...).
Another user even created a bug-report to the GCMD-packager of openSUSE-distribution [3]. To be honest, this also was my first idea...
Ok, all I wanted to say is, that current GCMD-terminal-setting now, that doesn't work, might be confusion and should be handled as bug instead of desired feature.

Thanks and Regards,
Frank

[1] GCMD-Menue: Settings ==> Options ==> Programs ==> Terminal
[2] http://ubuntuforums.org/showthread.php?t=1279781
[3] https://bugzilla.novell.com/show_bug.cgi?id=844294
Comment 3 Uwe Scholz 2014-10-05 18:02:22 UTC
Hi Frank,

this problem has been fixed in gcmd's software repository [1]. The fix will go into
the next release, v1.4.4. Thank you for your detailed bug report.

Best wishes,
Uwe

[1] https://git.gnome.org/browse/gnome-commander/commit/?h=gcmd-1-4&id=6a2773c226b1f0c1d408b8e6f3d776e89152b34a
Comment 4 frawoh 2014-10-08 06:41:02 UTC
Hi Uwe,

thanks for your great work on this!
I upgraded my GCMD with your fix above and wanted to let you know following findings:

a) terminal button (and also right-mouse "open terminal here") works perfect now

b) "Shift"+terminal button (open terminal as root) still opens the gnome-terminal here, but maybe I did something wrong?!
[function command_open_terminal_as_root in file ./src/gnome-cmd-user-actions.cc doesn't seem to be updated with new parameter gnome_cmd_data.options.termexec, but maybe I really did something wrong when implementing your bugfix...]

Thanks again, I love this terminal-button now... :-)

Cheers,
Frank
Comment 5 Uwe Scholz 2014-10-11 06:57:09 UTC
Hi Frank,

thank your very much for your hint. You have been completely right - I forgot to adapt command_open_terminal_as_root(). This is fixed now.

Best wishes
Uwe
Comment 6 frawoh 2014-10-12 18:30:13 UTC
Hi Uwe,

just wanted to let you know that I implemented your recent changes at function command_open_terminal_as_root into my system...
It works as expected now! Well done! Perfect!

Thanks a lot to you and the whole developer-team!!!

Cheers,
Frank