After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737078 - [PATCH] Remove place().
[PATCH] Remove place().
Status: RESOLVED FIXED
Product: iagno
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: iagno-maint
iagno-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-21 15:26 UTC by Arnaud B.
Modified: 2014-09-21 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove place(). (3.01 KB, patch)
2014-09-21 15:26 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2014-09-21 15:26:46 UTC 
Created attachment 286741 [details] [review]
Remove place().

The function place() is called two times, with quite different goal: counting the number of tiles flipped by a move, and checking if there’s a move possible. It does just what is needed for the first case; but for the second, it is doing much more work than needed, as it continue to check all direction even after one had revealed a move was possible. Lets remove it.
Comment 1 Michael Catanzaro 2014-09-21 17:08:03 UTC 
Nothing seems broken.

Attachment 286741 [details] pushed as 6e874f3 - Remove place().