After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737068 - some icons dont obey theme colors
some icons dont obey theme colors
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-21 08:59 UTC by Lasse Schuirmann
Modified: 2014-10-10 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
maps with dark theme (402.46 KB, image/png)
2014-09-21 08:59 UTC, Lasse Schuirmann 		  Details
Add symbolic icons to icon theme (7.34 KB, patch)
2014-09-22 09:11 UTC, Jonas Danielsson 		committed Details | Review
After patch (380.46 KB, image/png)
2014-09-22 09:12 UTC, Jonas Danielsson 		  Details

Description Lasse Schuirmann 2014-09-21 08:59:51 UTC 
Created attachment 286724 [details]
maps with dark theme

the appended screenshot was made on archlinux using the gnome 3.13.92 release.

As you can see the non-theme icons are also black when using the dark theme which gives a very inconsistent look overall.
Comment 1 Matthias Clasen 2014-09-21 21:07:56 UTC 
For some of the buttons, this is because of:

<property name="pixbuf">layers-button.svg</property>

<property name="pixbuf">route-button</property>

For making symbolic recoloring work, these will have to be loaded from icon names.
Comment 2 Jonas Danielsson 2014-09-22 09:11:55 UTC 
Created attachment 286784 [details] [review]
Add symbolic icons to icon theme

Add the icons to our icon theme and use 'icon-name' property
instead of 'pixbuf' property. This will make recoloring work.
Comment 3 Jonas Danielsson 2014-09-22 09:12:20 UTC 
Created attachment 286785 [details]
After patch
Comment 4 Damián Nohales 2014-09-22 16:11:05 UTC 
Review of attachment 286784 [details] [review]:

Ack
Comment 5 Zeeshan Ali 2014-09-29 13:04:08 UTC 
(In reply to comment #4)
> Review of attachment 286784 [details] [review]:
> 
> Ack

Jonas, forgot to push?
Comment 6 Jonas Danielsson 2014-09-29 13:31:10 UTC 
No, talked to release-team and it was agreed to go in stable branch. It wasn't urgent enough since maps isn't default dark.

So... could push now I guess so it gets into 3.14.1
Comment 7 Jonas Danielsson 2014-10-10 17:49:46 UTC 
Attachment 286784 [details] pushed as 1d08fcb - Add symbolic icons to icon theme