After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737010 - Corrected some grammar mistakes in 'connect.page','create.page','system-requirements.page', and simplifies/clarified 'create.page'. No related bug.
Corrected some grammar mistakes in 'connect.page','create.page','system-requi...
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: documentation
unspecified
Other All
: Normal normal
: 3.22
Assigned To: Maintainers of Gnome user documentation
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-20 04:46 UTC by Alexander Hoffman
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Corrected some grammar mistakes in 'connect.page','create.page','system-requirements.page', and simplifies/clarified 'create.page'. No related bug. (4.01 KB, patch)
2014-09-20 04:46 UTC, Alexander Hoffman
none Details | Review
Fixes issues with original patch from bug 737010 (3.80 KB, patch)
2014-09-20 18:41 UTC, Alexander Hoffman
accepted-commit_now Details | Review
help: fix, clarify connect, create, sys-reqs pages (3.86 KB, patch)
2014-09-21 14:02 UTC, Michael Hill
committed Details | Review

Description Alexander Hoffman 2014-09-20 04:46:48 UTC
The documentation is more clear particularly in the installation sources list on the create.page.

I have not contributed to the GNOME project before, so please let me know if I'm doing anything wrong.
Comment 1 Alexander Hoffman 2014-09-20 04:46:51 UTC
Created attachment 286677 [details] [review]
Corrected some grammar mistakes in 'connect.page','create.page','system-requirements.page', and simplifies/clarified 'create.page'. No related bug.
Comment 2 André Klapper 2014-09-20 10:47:43 UTC
Thanks for your page! In general very welcome. :)

One small question:

 A local virtual machine
+    can be created from:</p>
-        <item><p>inserting installation media in your CD/DVD drive or USB
-        port.</p></item>
+        <item><p>A CD/DVD/USB drive.</p></item>

This change sounds like I can create a virtual machine from a hardware drive, but isn't it rather the media inserted in that drive?
Comment 3 Michael Hill 2014-09-20 14:46:07 UTC
Review of attachment 286677 [details] [review]:

Thanks for the patch!

::: help/C/create.page
@@ +47,3 @@
     </item>
 
+    <item><p>After making your selection, and providing any necessary

"or" was correct here. You can click Continue after selecting an ISO or entering a URL. If you do either one, no further information is entered until after clicking Continue.
Comment 4 Alexander Hoffman 2014-09-20 18:34:00 UTC
@André Klapper: You are right, it should be more specific. I'll upload a new patch shortly with a fix!

@Michael Hill: You are also right, I've changed that back to how you guys had it before, which will also be included in the new patch I'll upload in a bit.

Thank you guys for the comments! There'll be a new patch shortly.
Comment 5 Alexander Hoffman 2014-09-20 18:41:13 UTC
Created attachment 286701 [details] [review]
Fixes issues with original patch from bug 737010
Comment 6 Michael Hill 2014-09-20 21:39:36 UTC
Comment on attachment 286701 [details] [review]
Fixes issues with original patch from bug 737010

Looks good, Alexander. Are you able to commit this?
Comment 7 Lasse Schuirmann 2014-09-20 21:57:37 UTC
A small thing: I think it would be nice to have something more meaningful in the commit message so we don't have to look into the commit or into this bug to get what's this about.

Welcome from me too! And thanks for the patch.
Comment 8 Alexander Hoffman 2014-09-21 08:38:52 UTC
I am not able to commit (or push, if that's what you mean) these changes, as I do not have those privileges, as far as I know. If I'm missing something, just let me know.

I'll make sure to be more meaningful in my commit message in the future.
Comment 9 Michael Hill 2014-09-21 14:02:46 UTC
Created attachment 286739 [details] [review]
help: fix, clarify connect, create, sys-reqs pages
Comment 10 Michael Hill 2014-09-21 14:05:55 UTC
Attachment 286739 [details] pushed as 7e7a20b - help: fix, clarify connect, create, sys-reqs pages