Bug 736962 – [PATCH] master nmcli crashes upon connection creation

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 736962 - [PATCH] master nmcli crashes upon connection creation


Summary:	[PATCH] master nmcli crashes upon connection creation


Status:	RESOLVED FIXED

Product:	NetworkManager
Classification:	Platform
Component:	general
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	NetworkManager maintainer(s)
QA Contact:	NetworkManager maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-09-19 11:25 UTC by Lubomir Rintel
Modified:	2014-09-19 12:33 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
[PATCH] libnm: avoid init_async NULL dereference on cancellable=0x0 (5.78 KB, patch) 2014-09-19 11:25 UTC, Lubomir Rintel	committed	Details \| Review

Description Lubomir Rintel 2014-09-19 11:25:22 UTC

Created attachment 286614 [details] [review]
[PATCH] libnm: avoid init_async NULL dereference on cancellable=0x0

(gdb) run c add type bond
Starting program: /usr/bin/nmcli c add type bond
Got object file from memory but can't read symbols: File truncated.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
[New Thread 0x7ffff39b2700 (LWP 13042)]
[New Thread 0x7fffec4bc700 (LWP 13043)]

(process:13038): GLib-GObject-CRITICAL **: g_object_ref: assertion 'G_IS_OBJECT (object)' failed

Program received signal SIGTRAP, Trace/breakpoint trap.
g_logv (log_domain=0x7ffff5cda224 "GLib-GObject", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffd290) at gmessages.c:1046
1046              g_private_set (&g_log_depth, GUINT_TO_POINTER (depth));
(gdb) bt

+ Trace 234109

#0 g_logv
at gmessages.c line 1046
#1 g_log
at gmessages.c line 1079
#2 g_return_if_fail_warning
#3 g_object_ref
at gobject.c line 3041
#4 _nm_dbus_new_connection_async
at nm-dbus-helpers.c line 131
#5 handle_property_changed
at nm-object.c line 1115
#6 handle_property_changed
at nm-object.c line 1
#7 process_properties_changed
at nm-object.c line 1218
#8 property_proxy_signal
at nm-object.c line 1234
#9 ffi_call_unix64
at ../src/x86/unix64.S line 76
#10 ffi_call
at ../src/x86/ffi64.c line 525
#15 <emit signal ??? on instance 0x555555881c10 [NMDBusSettingsProxy]>
at gsignal.c line 3365
#16 on_signal_received
#17 emit_signal_instance_in_idle_cb
at gdbusconnection.c line 3753
#18 g_main_context_dispatch
at gmain.c line 3064
#19 g_main_context_dispatch
at gmain.c line 3663
#20 g_main_context_iterate
at gmain.c line 3734
#21 g_main_loop_run
at gmain.c line 3928
#22 main
at nmcli.c line 587

Comment 1 Dan Winship 2014-09-19 12:33:44 UTC

Oops. committed.