After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736925 - Remove deprecation warnings from AlbumWidget.ui
Remove deprecation warnings from AlbumWidget.ui
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-18 19:00 UTC by Kris Thomsen
Modified: 2014-09-22 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (4.47 KB, patch)
2014-09-18 19:07 UTC, Kris Thomsen
accepted-commit_after_freeze Details | Review

Description Kris Thomsen 2014-09-18 19:00:45 UTC
Replace / Remove the new deprecations (GTK 3.13/3.14) from AlbumWidget.ui
Comment 1 Kris Thomsen 2014-09-18 19:07:00 UTC
Created attachment 286529 [details] [review]
Proposed patch
Comment 2 Vadim Rutkovsky 2014-09-22 05:51:02 UTC
Review of attachment 286529 [details] [review]:

Looks good to me
Comment 3 Vadim Rutkovsky 2014-09-22 14:16:04 UTC
Thanks for your patch, pushed 
https://git.gnome.org/browse/gnome-music/commit/?id=ecd49f1 to gnome-3-14 and
https://git.gnome.org/browse/gnome-music/commit/?id=0eaf081 to master/

Some other warnings remain, however we can later on fix those.