After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736915 - window: Fix titlebar_is_onscreen() test
window: Fix titlebar_is_onscreen() test
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-09-18 15:34 UTC by Florian Müllner
Modified: 2014-09-22 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Fix titlebar_is_onscreen() test (1.44 KB, patch)
2014-09-18 15:34 UTC, Florian Müllner 		committed Details | Review
constraints: Fix update_onscreen_requirements() (1.12 KB, patch)
2014-09-18 15:46 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-09-18 15:34:04 UTC 
See patch.
Comment 1 Florian Müllner 2014-09-18 15:34:07 UTC 
Created attachment 286515 [details] [review]
window: Fix titlebar_is_onscreen() test

The titlebar rect is in window coordinates, while screen regions are
obviously not. Fix by translating into screen coordinates before
testing for overlaps.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-09-18 15:39:41 UTC 
Review of attachment 286515 [details] [review]:

Whoops, yeah.
Comment 3 Florian Müllner 2014-09-18 15:46:17 UTC 
Created attachment 286517 [details] [review]
constraints: Fix update_onscreen_requirements()

Another missing translation into screen coordinates ...
Comment 4 drago01 2014-09-21 17:23:22 UTC 
Review of attachment 286517 [details] [review]:

LG.
Comment 5 Florian Müllner 2014-09-22 18:19:34 UTC 
Attachment 286515 [details] pushed as 73ca0ef - window: Fix titlebar_is_onscreen() test
Attachment 286517 [details] pushed as 90bd02f - constraints: Fix update_onscreen_requirements()