GNOME Bugzilla – Bug 736905
videomixer: Removed unwanted instruction
Last modified: 2015-02-13 11:51:07 UTC
Created attachment 286497 [details] [review] videomixer: Removed unwanted instruction Removed unwanted instruction
It would be nice if you could explain a bit better why we do not need that instruction in the commit message. Also it would be great if you could have a look at compositior/videoaggregator instead of videomixer as the goal is to replace the videomixer implementation by the compositor one during that 1.6 cycle.
Also please put the Bugzilla URL into the commit message as a last line
Sorry I pulled code and getting compilation error. Will submit these changes on Monday
Created attachment 287150 [details] [review] videomixer: Removed redundant instruction Updated the Patch as per the comments start_time *= ABS (mix->segment.rate); In function gst_videomixer2_sink_clip, after the above assignment start_time is nowhere used. So removed this instruction.
Comment on attachment 287150 [details] [review] videomixer: Removed redundant instruction Note that start_time is assigned and not really used above that too. Did you check if the same change is relevant to compositor / videoaggregator too?
Created attachment 288091 [details] [review] videoaggregator: Removed unnecessary assignment videoaggregator: Removed unnecessary assignment Below instruction is not required as start_time is not used after this assignment start_time *= ABS (agg->segment.rate);
start_time is used before this assignment in videomixer start_time = MAX (start_time, mixcol->collect.segment.start); start_time = gst_segment_to_running_time (&mixcol->collect.segment, GST_FORMAT_TIME, start_time); Verified videoaggregator and have made changes in that too, have submitted a patch for the same
(In reply to comment #7) > start_time is used before this assignment in videomixer > > start_time = MAX (start_time, mixcol->collect.segment.start); > start_time = > gst_segment_to_running_time (&mixcol->collect.segment, > GST_FORMAT_TIME, start_time); It's only assigned but never really used... thus can go away
Created attachment 288183 [details] [review] videoaggregator: Removed unwanted assignment to start_time Removed unwanted assignment to start_time as start_time is not being used after this assignment
Created attachment 288184 [details] [review] videomixer: Removed unwanted assignment to start_time start_time is not being used after assignments in function gst_videomixer2_sink_clip. Removed these assignments
In the latest code of gstvideoaggregator, this is already included may be by some other patch. So this patch is now obsolete