After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736897 - videobox: duplicate assignment
videobox: duplicate assignment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal trivial
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-18 12:40 UTC by Sanjay NM
Modified: 2014-09-23 23:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sanjay NM 2014-09-18 12:40:15 UTC 
In File gstvideobox.c line 1954, dest = GST_VIDEO_FRAME_PLANE_DATA (dest_frame, 0); is present. It is not used till line 1971 where dest is getting over written with the same function call. May be one of the calls is not required. Request to please review.
Comment 1 Sanjay NM 2014-09-18 12:42:05 UTC 
Same with src pointer at line 2062
Comment 2 Sebastian Dröge (slomo) 2014-09-23 20:27:11 UTC 
You forgot to attach the patch
Comment 3 Tim-Philipp Müller 2014-09-23 23:13:28 UTC 
commit 208e12dca2ef75b49e9ae0450f7b7b63ba25300c
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Wed Sep 24 00:12:14 2014 +0100

    videobox: remove duplicate assignments
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736897