After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736843 - MiniObject.MakeWritable doesn't work
MiniObject.MakeWritable doesn't work
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-sharp
1.4.0
Other Windows
: Normal normal
: 1.0.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-18 03:05 UTC by Tom Deseyn
Modified: 2014-11-08 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.21 KB, patch)
2014-09-18 09:58 UTC, Tom Deseyn 		committed Details | Review

Description Tom Deseyn 2014-09-18 03:05:44 UTC 
MiniObject: fix MakeWritable

In case the MiniObject had a reference count of 1 (writable), the object was destroyed due to a bug in Opaque not handling self-assignment of Raw.
In case the MiniObject was not writable, the returned copy was not writable either because it had two references: one from gst_mini_object_make_writable and one from Opaque.Raw.
Comment 1 Tom Deseyn 2014-09-18 09:58:16 UTC 
Created attachment 286459 [details] [review]
patch
Comment 2 Stephan Sundermann 2014-09-18 13:11:16 UTC 
Thanks for the patch, I applied it in master.