After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736830 - GtkVolumeButton reaction inverted on scrolling action when "opened" and "closed"
GtkVolumeButton reaction inverted on scrolling action when "opened" and "closed"
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-09-17 19:36 UTC by Branko Grubic (bitlord)
Modified: 2014-09-23 00:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scalebutton: Invert smooth scroll dy when adding to the current value (1.18 KB, patch)
2014-09-18 11:58 UTC, Carlos Garnacho 		committed Details | Review

Description Branko Grubic (bitlord) 2014-09-17 19:36:03 UTC 
In rhythmbox-3.0.3-4.fc21.x86_64 there is a volume button and when you scroll over it (without opening/clicking) it changes volume, but volume events are inverted, and when you open it and slider is present, scrolling over slider works properly (not inverted). I'm not sure if this is a gtk+ bug or rhythmbox, someone on IRC reported same experience with other "application". I'll ask him to comment on this bug. 

gtk3-3.13.8-1.fc21.x86_64
Comment 1 Branko Grubic (bitlord) 2014-09-17 19:51:41 UTC 
maybe related to this https://bugzilla.gnome.org/show_bug.cgi?id=710849  
Also some other "widgets" are broken, in rhythmbox "progress" slider, or in system-settings > sound all sliders are inverted or in system-settings > mouse&touchpad ... 
I'm using default mouse scrolling directions. 
Maybe this is not just about GtkVolumeButton
Comment 2 Jonathan Matthew 2014-09-17 22:41:54 UTC 
It looks like GtkScaleButton applies GDK_SCROLL_SMOOTH events backwards with respect to how it applies GDK_SCROLL_UP/DOWN events.  GDK_SCROLL_UP increases the scale value by the adjustment step value.  GDK_SCROLL_SMOOTH events for scrolling up have negative event->delta_y, so the scale value is decreased.
Comment 3 Carlos Garnacho 2014-09-18 11:58:45 UTC 
Created attachment 286481 [details] [review]
scalebutton: Invert smooth scroll dy when adding to the current value

On regular scrolling (ie. not natural scrolling), positive deltas in the
Y axis (downwards) should actually move the value towards the adjustment
minimum value to be more intuitive. This also makes the scrolling
directions match between the button and the popped up scale.
Comment 4 Jonathan Matthew 2014-09-18 21:57:06 UTC 
That's what I did too, if that helps at all.
Comment 5 Matthias Clasen 2014-09-18 22:18:45 UTC 
Review of attachment 286481 [details] [review]:

ok
Comment 6 Matthias Clasen 2014-09-23 00:28:48 UTC 
Attachment 286481 [details] pushed as f8f74b5 - scalebutton: Invert smooth scroll dy when adding to the current value