After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736803 - Allow route to contact
Allow route to contact
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on: 741591
Blocks:
 
 
Reported: 2014-09-17 14:17 UTC by Zeeshan Ali
Modified: 2015-01-31 23:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
placeStore: Add contact type to place store (2.08 KB, patch)
2015-01-12 11:54 UTC, Jonas Danielsson
none Details | Review
contact: Add custom unique id (774 bytes, patch)
2015-01-12 11:54 UTC, Jonas Danielsson
none Details | Review
placeBubble: Do not add favorite button for contacts (1.02 KB, patch)
2015-01-12 11:54 UTC, Jonas Danielsson
none Details | Review
mapView: Use ContactMarker for contacts (1.14 KB, patch)
2015-01-12 11:54 UTC, Jonas Danielsson
none Details | Review
application: Add contacts to place store (1.73 KB, patch)
2015-01-12 11:54 UTC, Jonas Danielsson
none Details | Review
Cast of searching and routing to contacts (1.56 MB, video/webm)
2015-01-12 11:55 UTC, Jonas Danielsson
  Details
placeStore: Add contact type to place store (2.08 KB, patch)
2015-01-12 14:21 UTC, Jonas Danielsson
none Details | Review
placeListRow: Add avatar icon for contact (915 bytes, patch)
2015-01-12 14:21 UTC, Jonas Danielsson
none Details | Review
contact: Add custom unique id (774 bytes, patch)
2015-01-12 14:21 UTC, Jonas Danielsson
none Details | Review
placeBubble: Do not add favorite button for contacts (1.02 KB, patch)
2015-01-12 14:21 UTC, Jonas Danielsson
none Details | Review
application: Add contacts to place store (1.73 KB, patch)
2015-01-12 14:21 UTC, Jonas Danielsson
none Details | Review
placeStore: Add contact type to place store (1.39 KB, patch)
2015-01-13 08:49 UTC, Jonas Danielsson
none Details | Review
placeListRow: Add avatar icon for contact (915 bytes, patch)
2015-01-13 08:49 UTC, Jonas Danielsson
none Details | Review
application: Add contacts to place store (1.73 KB, patch)
2015-01-13 08:50 UTC, Jonas Danielsson
none Details | Review
application: Add contacts to place store (1.86 KB, patch)
2015-01-13 14:39 UTC, Jonas Danielsson
none Details | Review
placeStore: Add contact type to place store (1.41 KB, patch)
2015-01-30 22:21 UTC, Jonas Danielsson
committed Details | Review
placeListRow: Add avatar icon for contact (915 bytes, patch)
2015-01-30 22:21 UTC, Jonas Danielsson
committed Details | Review
application: Add contacts to place store (2.39 KB, patch)
2015-01-30 22:22 UTC, Jonas Danielsson
committed Details | Review

Description Zeeshan Ali 2014-09-17 14:17:33 UTC
Would be really cool if we could allow user to enter contact's name in the 'To' entry and we complete it, if we got an address for that contact and then automatically substitute it in the entry. If we know last check-in (and its recent enough) we could give an option for use to choose "Fred's last known location" or "Fred's home".
Comment 1 Jonas Danielsson 2014-10-01 08:55:53 UTC
Ths could be done by using libfolks in Maps, it is what Contacts uses for backend: https://wiki.gnome.org/Projects/Folks/

Quote from Philip Withnall:

> For displaying contact details, you might want to just open Contacts to
> view a specific contact. For tighter integration, e.g. displaying
> contacts on a map, you should use libfolks directly, which is the
> backend Contacts uses.
Comment 2 Jonas Danielsson 2014-12-02 06:55:50 UTC
So,

Some comments/questions.
Say we get the contacts from libfolks, and add them to the store at some point so we can complete against them.

When do we perform the geocode lookup of the address? And what visual hint should we provide that we are doing this?

Also, maybe we should use Nominatim's structured request?
http://wiki.openstreetmap.org/wiki/Nominatim#Parameters

"street=<housenumber> <streetname>
 city=<city>
 county=<county>
 state=<state>
 country=<country>
 postalcode=<postalcode>
   (experimental) Alternative query string format for structured requests. 
   Structured requests are faster and require less server resources. 
   DO NOT COMBINE WITH q=<query> PARAMETER."

We could add a geocode_forward_new_from_place or something like that to get an interface to search with this. Maybe it gives better results as well? You can try with your own address:

http://nominatim.openstreetmap.org/?street=&city=&state=&postalcode=&format=jsonv2&addressdetails=1
Comment 3 Jonas Danielsson 2014-12-02 10:45:18 UTC
Or maybe we can just use the geocode_forward_new_for_params, we might have to add something to allow all the ones we need.
Comment 4 Jonas Danielsson 2015-01-12 11:54:28 UTC
Created attachment 294337 [details] [review]
placeStore: Add contact type to place store
Comment 5 Jonas Danielsson 2015-01-12 11:54:33 UTC
Created attachment 294338 [details] [review]
contact: Add custom unique id

Make sure contacts to not clash in placeStore even if more than one
points to the same OpenStreetMap object.
Comment 6 Jonas Danielsson 2015-01-12 11:54:37 UTC
Created attachment 294339 [details] [review]
placeBubble: Do not add favorite button for contacts
Comment 7 Jonas Danielsson 2015-01-12 11:54:40 UTC
Created attachment 294340 [details] [review]
mapView: Use ContactMarker for contacts
Comment 8 Jonas Danielsson 2015-01-12 11:54:45 UTC
Created attachment 294341 [details] [review]
application: Add contacts to place store
Comment 9 Jonas Danielsson 2015-01-12 11:55:26 UTC
Created attachment 294342 [details]
Cast of searching and routing to contacts
Comment 10 Jonas Danielsson 2015-01-12 11:58:04 UTC
So this adds contacts to the placeStore in startup, it only adds those that we are able to geocode to a lat/lon.

It will geocode async, so it will take a short while before the contacts are added. The geocode cache will work in our favour here I guess.

Some things that might need addressing: Other completes in the place store have an icon to indicate their type, like recent and favorite. Is there an icon we could use for contact?

I do not want to store the contacts in our json file, because I do not really now how to serialize and de-serialize the contact. Or rather, the avatar pixbuf.
So I dunno how I would keep track of the contact being a favorite.
Comment 11 Jonas Danielsson 2015-01-12 14:21:01 UTC
Created attachment 294358 [details] [review]
placeStore: Add contact type to place store
Comment 12 Jonas Danielsson 2015-01-12 14:21:05 UTC
Created attachment 294359 [details] [review]
placeListRow: Add avatar icon for contact
Comment 13 Jonas Danielsson 2015-01-12 14:21:10 UTC
Created attachment 294360 [details] [review]
contact: Add custom unique id

Make sure contacts to not clash in placeStore even if more than one
points to the same OpenStreetMap object.
Comment 14 Jonas Danielsson 2015-01-12 14:21:14 UTC
Created attachment 294361 [details] [review]
placeBubble: Do not add favorite button for contacts
Comment 15 Jonas Danielsson 2015-01-12 14:21:18 UTC
Created attachment 294362 [details] [review]
application: Add contacts to place store
Comment 16 Jonas Danielsson 2015-01-13 08:49:55 UTC
Created attachment 294402 [details] [review]
placeStore: Add contact type to place store
Comment 17 Jonas Danielsson 2015-01-13 08:49:59 UTC
Created attachment 294403 [details] [review]
placeListRow: Add avatar icon for contact
Comment 18 Jonas Danielsson 2015-01-13 08:50:04 UTC
Created attachment 294404 [details] [review]
application: Add contacts to place store
Comment 19 Jonas Danielsson 2015-01-13 14:39:31 UTC
Created attachment 294437 [details] [review]
application: Add contacts to place store
Comment 20 Jonas Danielsson 2015-01-30 22:21:40 UTC
Created attachment 295831 [details] [review]
placeStore: Add contact type to place store
Comment 21 Jonas Danielsson 2015-01-30 22:21:50 UTC
Created attachment 295832 [details] [review]
placeListRow: Add avatar icon for contact
Comment 22 Jonas Danielsson 2015-01-30 22:22:02 UTC
Created attachment 295833 [details] [review]
application: Add contacts to place store
Comment 23 Jonas Danielsson 2015-01-31 23:51:46 UTC
Attachment 295831 [details] pushed as 22c8681 - placeStore: Add contact type to place store
Attachment 295832 [details] pushed as 369835a - placeListRow: Add avatar icon for contact
Attachment 295833 [details] pushed as 09adee6 - application: Add contacts to place store