GNOME Bugzilla – Bug 736781
vc1parse: forge sequence-layer from seq_hdr instead of seq_layer
Last modified: 2014-09-17 08:38:10 UTC
Hi all, I found something strange in this vc1parse piece of code: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/videoparsers/gstvc1parse.c#n676 When we want VC1_HEADER_FORMAT_ASF + simple/main profile and we don't have seq_hdr_buffer, we forge it with seq_layer. But when we want VC1_HEADER_FORMAT_SEQUENCE_LAYER and we don't have a seq_layer_buffer, we forge it with seq_layer. Since seq_layer and seq_layer_buffer are set when parsing the sequence-layer, if we don't have a seq_layer_buffer, we won't have a valid seq_layer. Therefore, I think it seq_layer_buffer should be forged from seq_hdr but I'm not sure. What is your opinion ?
Created attachment 286345 [details] [review] vc1parse: forge sequence-layer from seq_hdr instead of seq_layer I prepare a patch for this if confirmed.
commit de141c323737ca4bb3a28ce44e06a00d81966486 Author: Aurélien Zanelli <aurelien.zanelli@parrot.com> Date: Tue Sep 16 17:38:53 2014 +0200 vc1parse: forge sequence-layer from seq_hdr instead of seq_layer If we don't have a seq_layer_buffer, we also don't have a valid seq_layer because there are set together in gst_vc1_parse_handle_seq_layer(). So when output header format is sequence-layer and when we don't have a seq_layer_buffer, we forge one from seq_hdr. https://bugzilla.gnome.org/show_bug.cgi?id=736781