After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736779 - typefind: h265 IRAP picture always true
typefind: h265 IRAP picture always true
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.4.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-17 05:12 UTC by RaviKiran
Modified: 2014-09-17 07:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
correct condition for irap flag (1016 bytes, patch)
2014-09-17 05:15 UTC, RaviKiran 		committed Details | Review

Description RaviKiran 2014-09-17 05:12:50 UTC 
In gsttypefindfunction, seen_irap always evaluates to true due to typo '||' (it should be '&&')

        else if (nut >= 16 || nut <= 21) {
          /* BLA, IDR and CRA pictures are belongs to be IRAP picture */
          /* we are not counting the reserved IRAP pictures (22 and 23) to good */
          seen_irap = TRUE;
        }
Comment 1 RaviKiran 2014-09-17 05:15:51 UTC 
Created attachment 286339 [details] [review]
correct condition for irap flag

Patch attached. Please review.
Comment 2 Sebastian Dröge (slomo) 2014-09-17 06:42:08 UTC 
commit cf98138c7ed1d1ea3f88b3156d07c67c72710e06
Author: Ravi Kiran K N <ravi.kiran@samsung.com>
Date:   Wed Sep 17 10:51:59 2014 +0530

    typefind: correct the condition for irap flag
    
    https://bugzilla.gnome.org/show_bug.cgi?id=736779