After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736776 - language: don't call g_variant_dup_string() on a NULL variant
language: don't call g_variant_dup_string() on a NULL variant
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-17 00:58 UTC by Cosimo Cecchi
Modified: 2015-01-25 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.11 KB, patch)
2014-09-17 00:59 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2014-09-17 00:58:35 UTC 
See patch
Comment 1 Cosimo Cecchi 2014-09-17 00:59:05 UTC 
Created attachment 286334 [details] [review]
patch

g_dbus_proxy_get_cached_property() can return NULL. Guard against that
case.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-09-17 01:15:13 UTC 
This should probably also be pushed to g-c-c as well. But the codebases are also probably considerably out of sync at this point.
Comment 3 Rui Matos 2014-09-18 15:14:05 UTC 
Review of attachment 286334 [details] [review]:

looks good
Comment 4 Rui Matos 2014-09-18 15:14:57 UTC 
(In reply to comment #2)
> This should probably also be pushed to g-c-c as well. But the codebases are
> also probably considerably out of sync at this point.

This was already fixed in g-c-c's copy.
Comment 5 André Klapper 2015-01-24 08:58:02 UTC 
ping - Patch here is set to "accepted-commit_after_freeze" and might be nice to get it in before it is again blocke by a freeze.
Comment 6 Cosimo Cecchi 2015-01-25 15:18:48 UTC 
Pushed to master now.