Created attachment 286315 [details] [review]
keyboard: Remove dead code

This is already done a few lines earlier.

Created attachment 286316 [details] [review]
keyboard: Disregard the current locale when adding IBus engines

Similarly to 198e3bbb080109188d21482214ca829ecbd19628 we should
include all the relevant IBus engines.

Created attachment 286317 [details] [review]
keyboard: Add the default input source regardless of type

Some locales suggest an IBus engine as default input source. We should
add it to the list and if we haven't been able to fetch the engine
descriptions from IBus yet we use the id as label. Note that as soon
as we connect to IBus and get the descriptions we'll update the label,
see update_ibus_active_sources() .

Created attachment 286318 [details] [review]
keyboard: Ellipsize input source labels

Some input sources have unreasonably long labels which might make us
too wide. Ellipsize them.

Review of attachment 286315 [details] [review]:

sure

Review of attachment 286316 [details] [review]:

ok

Review of attachment 286317 [details] [review]:

ok

Review of attachment 286318 [details] [review]:

makes sense

can you ask for a freeze break for these ?

Attachment 286315 [details] pushed as f17838d - keyboard: Remove dead code
Attachment 286316 [details] pushed as 5f0a764 - keyboard: Disregard the current locale when adding IBus engines
Attachment 286318 [details] pushed as 2037d6b - keyboard: Ellipsize input source labels